Skip to content

fix: v2 guide gaps, retry changeset, panic log and negative ai settings - #404

Merged
eli-r-ph merged 8 commits into
v1from
eli/v1-review-fixes
Nov 2, 2026
Merged

eli-r-ph merged 8 commits into
v1from
eli/v1-review-fixes

Conversation

@eli-r-ph

@eli-r-ph eli-r-ph commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

💡 Motivation and Context

A review of the v2 migration guide against the v1 code found upgrade risks the guide didn't mention, a changeset that contradicts the code, and two rule gaps. The biggest guide gap: DefaultEventOptions, request-context options and a $process_person_profile default now reach Identify, Alias and GroupIdentify, so a personless default makes PostHog drop those events with no Callback report.

Changes

  • Guide: warn about the personless default on person-only messages, whitespace-only ids returning FieldError, log text changes, AI lane settings that are not inherited, Alias/Backoff no longer comparable with ==, and the proxy Authorization rule.
  • Changeset: replace "429 is no longer retried" with the real retry list (404, 408, 429, 500, 502, 503, 504 and network errors).
  • A panicking BeforeSend now logs the event name and the panic's type, never the panic value, which can hold the data the hook was removing.
  • Config.Validate rejects a negative CaptureAIBatchUploadTimeout (it meant no timeout) and CaptureAIMaxQueueSize (it quietly became the default).

💚 How did you test it?

  • New test for the panic log across all five message types; it fails on the old code.
  • TestConfigRejectsNegativeKnobs covers both new fields.
  • go test ./..., go vet ./..., gofmt, go mod tidy and make api-diff pass.

📝 Checklist

  • All commits are signed (see Commit signing)
  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran pnpm changeset to generate a changeset file

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

  • Written with Claude Code (claude-opus-5-5) from a review of the guide and changesets against v1 and the capture service.

🤖 Generated with Claude Code

eli-r-ph and others added 5 commits November 1, 2026 12:53
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@eli-r-ph
eli-r-ph requested a review from a team as a code owner November 1, 2026 21:01
eli-r-ph and others added 3 commits November 1, 2026 13:11
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@eli-r-ph eli-r-ph mentioned this pull request Nov 1, 2026
4 of 6 tasks

@marandaneto marandaneto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good; no qualifying findings. Verdict: correct.

@eli-r-ph
eli-r-ph merged commit 2a34dd8 into v1 Nov 2, 2026
32 checks passed
@eli-r-ph
eli-r-ph deleted the eli/v1-review-fixes branch November 2, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants