Repository navigation
fix: v2 guide gaps, retry changeset, panic log and negative ai settings - #404
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 of 6 tasks
marandaneto
approved these changes
Nov 2, 2026
marandaneto
left a comment
Member
There was a problem hiding this comment.
The code looks good; no qualifying findings. Verdict: correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
A review of the v2 migration guide against the
v1code found upgrade risks the guide didn't mention, a changeset that contradicts the code, and two rule gaps. The biggest guide gap:DefaultEventOptions, request-context options and a$process_person_profiledefault now reachIdentify,AliasandGroupIdentify, so a personless default makes PostHog drop those events with noCallbackreport.Changes
FieldError, log text changes, AI lane settings that are not inherited,Alias/Backoffno longer comparable with==, and the proxyAuthorizationrule.BeforeSendnow logs the event name and the panic's type, never the panic value, which can hold the data the hook was removing.Config.Validaterejects a negativeCaptureAIBatchUploadTimeout(it meant no timeout) andCaptureAIMaxQueueSize(it quietly became the default).💚 How did you test it?
TestConfigRejectsNegativeKnobscovers both new fields.go test ./...,go vet ./...,gofmt,go mod tidyandmake api-diffpass.📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
claude-opus-5-5) from a review of the guide and changesets againstv1and the capture service.🤖 Generated with Claude Code