Skip to content
This repository was archived by the owner on Nov 4, 2021. It is now read-only.

Update ts-node for M1 support with workers - #463

Merged
Twixes merged 10 commits into
masterfrom
ts-update
Jun 8, 2021
Merged

Update ts-node for M1 support with workers#463
Twixes merged 10 commits into
masterfrom
ts-update

Conversation

@mariusandra

Copy link
Copy Markdown
Collaborator

Changes

  • Resolves yarn start:dev is hanging (running on M1) #370
  • After these changes, the workers started again for me on my M1 Air.
  • I was now running NodeJS 16.3, but I'd expect it to work on other versions.
  • The TS update required some changes to a few places. Probably !! would have done the trick as well. Not sure why it errored there though, as value had undefined as one of its type options, so 🤷

Checklist

  • Updated Settings section in README.md, if settings are affected
  • Jest tests

@neilkakkar

neilkakkar commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

The undefined (and few others in tests) weirdness could be because:


WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.2.0

YOUR TYPESCRIPT VERSION: 4.3.2

Please only submit bug reports when using the officially supported version.

@mariusandra

Copy link
Copy Markdown
Collaborator Author

Good point. I bumped all the eslint packages as well.

@mariusandra

Copy link
Copy Markdown
Collaborator Author

This is trickier than I expected. I need to upgrade ts-node to v27 to fix those TS errors, but that requires at least NodeJS 14.15.0.

I have 14.5.0 installed and personally have no problem upgrading, but what about all our clients? What nodejs version are they running? I remember when we created the plugin server, a lot of customers said they had to explicitly upgrade their node versions to 14 for it to work. What frustrations will this change bring if they now have to upgrade to 14.15?

I hence limited ts-node to the latest v26. 🤞

@mariusandra
mariusandra requested a review from alexkim205 June 7, 2021 20:07
@alexkim205

Copy link
Copy Markdown

Yes! Tested the branch locally and it works beautifully.

@mariusandra

Copy link
Copy Markdown
Collaborator Author

Great! Feel free to merge ;)

@Twixes
Twixes merged commit c627ceb into master Jun 8, 2021
@Twixes
Twixes deleted the ts-update branch June 8, 2021 11:25
fuziontech pushed a commit to PostHog/posthog that referenced this pull request Oct 12, 2021
…lugin-server#463)

* update ts-node for M1 support with workers

* bump eslint packages

* fix eslint prettier config

* revert to pre-eslint fix

* revert lazy undefined fix

* upgrade ts-jest to latest v26

* fix another TS issue

* fix two more errors

* Fix problem with conditional in a simpler way

Co-authored-by: Michael Matloka <dev@twixes.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

yarn start:dev is hanging (running on M1)

4 participants