This repository was archived by the owner on Nov 4, 2021. It is now read-only.
Conversation
2 tasks
Contributor
|
The undefined (and few others in tests) weirdness could be because: |
Collaborator
Author
|
Good point. I bumped all the eslint packages as well. |
Collaborator
Author
|
This is trickier than I expected. I need to upgrade I have 14.5.0 installed and personally have no problem upgrading, but what about all our clients? What nodejs version are they running? I remember when we created the plugin server, a lot of customers said they had to explicitly upgrade their node versions to 14 for it to work. What frustrations will this change bring if they now have to upgrade to 14.15? I hence limited |
|
Yes! Tested the branch locally and it works beautifully. |
alexkim205
approved these changes
Jun 7, 2021
Collaborator
Author
|
Great! Feel free to merge ;) |
Twixes
approved these changes
Jun 8, 2021
fuziontech
pushed a commit
to PostHog/posthog
that referenced
this pull request
Oct 12, 2021
…lugin-server#463) * update ts-node for M1 support with workers * bump eslint packages * fix eslint prettier config * revert to pre-eslint fix * revert lazy undefined fix * upgrade ts-jest to latest v26 * fix another TS issue * fix two more errors * Fix problem with conditional in a simpler way Co-authored-by: Michael Matloka <dev@twixes.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
!!would have done the trick as well. Not sure why it errored there though, asvaluehadundefinedas one of its type options, so 🤷Checklist