Run piscina worker in the main thread if concurrency at 1 - #449
Run piscina worker in the main thread if concurrency at 1#449mariusandra wants to merge 1 commit into
Conversation
|
Interesting, I was thinking of something similar for the "install/test" pool - since that one would have a single worker. Not quite sure if it's a great thing, since it means we'll be blocking on tasks in the main thread? (ain't a big deal when we're awaiting the responses anyway, but is a big deal otherwise) Regarding the implementation: curious if the |
|
I think in the real world, even with just one thread, we still want the piscina task pool. If for nothing else then to never block the main thread. That separation is precisely what you want with the install/test pool. The setting in this PR should probably be configured with a special |
|
I don't quite see why we'd want this, besides having a temporary hack to get the plugin server working on ARM. Tests should generally run the same code as production, shouldn't they? |
|
We could use this on the lowest heroku tiers as well to save some redis connections... |
|
I got the plugin server working on the M1, so this could effectively be closed. Having a completely separate code path for cheap heroku users doesn't sound wise. |
Changes
TASKS_PER_WORKERsupport)Where should we go with this, if anywhere?
Checklist