Add missing skilltype tags to minion skills.#5325
Merged
LocalIdentity merged 7 commits intoPathOfBuildingCommunity:devfrom Dec 30, 2022
Merged
Add missing skilltype tags to minion skills.#5325LocalIdentity merged 7 commits intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 7 commits intoPathOfBuildingCommunity:devfrom
Conversation
Fixes missing tags on the Chaos Aura skill that chaos golem can use. Also changes the skill type flags on minion instability to use the standard enums.
Member
|
This certainly works, but breaks if other things about the skill get updated in the future. I'd love to see an attempt at finding where the support gem flag hooks up to the damage for these types of skills to fix them properly. (or pursue the exclusion logic that was mentioned in Discord: #3932 ) |
|
Just wanted to mention that Stone Golem's Slam seems to be affected as well. It is not being supported by Multistrike, Melee Physical Damage, or Ruthless, to name a few. |
Paliak
changed the title
Contributor
|
shouldn't |
Paliak
changed the title
LocalIdentity
approved these changes
Dec 30, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5313 .
Description of the problem being solved:
Some minion skills seem to be missing flags and it's causing issues after #4628 was merged.
Still need to check that the template minion.txt file does not cause issues with exports.