Skip to content

Add support for several different spectres: Arena Master, Ruins Hellion (partial), Trial Windchaser, Aurid Synthete, Ancient Wraith, They of Tul, Ancient Suffering, Merveil's Retainer, Primal Crushclaw, and Primal Rhex Matriarch#3932

Merged
Wires77 merged 19 commits intoPathOfBuildingCommunity:devfrom
Lothrik:add-requested-spectres
Feb 4, 2022

Conversation

@Lothrik
Copy link
Contributor

@Lothrik Lothrik commented Jan 21, 2022

PoB: https://pastebin.com/5BWwNYxT

Trial Windchaser: Fixes #2598.
Arena Master: Fixes #1775.
Ruins Hellion: Fixes #2315. Fixes #743.
Ancient Wraith and Aurid Synthete: Fixes #2894.
Primal Rhex Matriarch: Fixes #3965.

Arena Master is used for its unique Arena Master's Presence skill that grants "20% increased Damage, Attack, Cast and Movement Speed" for 4 seconds with a.. 12 second cooldown apparently? I'm pretty sure this used to give 40% and had an 8 second cooldown — pretty severe nerf. I'm not convinced implementing this buff is worth the effort.

Ruins Hellion is apparently used for the "Enemies Taunted by you deal 30% less Damage with Hits and Ailments against other targets" component of its Rallying Cry skill, but PoB doesn't even implement effects like that for the player, never mind a minion that has ~8K HP and is apparently used for a taunt..?

Trial Windchaser and Aurid Synthete seem fully functional. Aurid Synthete has a lot of weird triggered spells.

Ancient Wraith has +1 curse and Enfeeble on Hit.. which seems extremely valuable but I'm not sure how to implement it.

Preview:

New config option ("enable buffs" -- note that both of these options default to Enabled):

Brief documentation:

@Lothrik
Copy link
Contributor Author

Lothrik commented Jan 21, 2022

I just noticed the DelveMonsterEnfeebleOnHit and AdditionalCurseOnEnemies_ entries in Ancient Wraith's modList. I'll see if I can get that mechanic working.

@Lothrik Lothrik added the enhancement New feature, calculation, or mod label Jan 21, 2022
@Lothrik Lothrik marked this pull request as draft January 21, 2022 17:13
@Lothrik
Copy link
Contributor Author

Lothrik commented Jan 22, 2022

Ancient Wraith's +1 curse and Enfeeble on Hit thing works now. I had to add support for like.. everything.. to get this working.

@Lothrik
Copy link
Contributor Author

Lothrik commented Jan 22, 2022

Added Ancient Suffering (Temporal Chains on Hit) spectres.

The two curse on hit spectres and Arena Master are basically 100% functional now.

They need to be set as the active spectre somewhere (not just in your spectre library) for their unique effects to show up properly under calcs.

Edit: Added They of Tul spectres, with full support for Snow Cloak.

Edit 2: Added support for SeawitchVulnerability cast by Merveil's Retainer spectres.

@Lothrik Lothrik marked this pull request as ready for review January 23, 2022 06:22
@Lothrik
Copy link
Contributor Author

Lothrik commented Jan 24, 2022

As the curses used by Ancient Suffering and Ancient Wraith can't be datamined and are relevant for #3930, I asked viperesque what the proper internal names are for their curse skills and replaced my placeholder internal names:

Ancient Wraith Enfeeble on hit is from the DelveMonsterEnfeebleOnHit mod

Ancient Suffering Temporal Chains on hit is from the MonsterChanceToTemporalChainsOnHit1 mod

@Lothrik
Copy link
Contributor Author

Lothrik commented Jan 27, 2022

Added Frigid Roar to Primal Crushclaw spectres and added Primal Rhex Matriarch spectres (plus their Thunderous Roar debuff). Both debuff values were confirmed by viperesque.

@Lothrik Lothrik force-pushed the add-requested-spectres branch from 0c00842 to c9a1eec Compare February 3, 2022 13:59
@Wires77 Wires77 changed the title Add several requested spectres Add support for several different spectres: Arena Master, Ruins Hellion (partial), Trial Windchaser, Aurid Synthete, Ancient Wraith, They of Tul, Ancient Suffering, Merveil's Retainer, Primal Crushclaw, and Primal Rhex Matriarch Feb 4, 2022
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Wires77 Wires77 merged commit 6983416 into PathOfBuildingCommunity:dev Feb 4, 2022
@Lothrik Lothrik deleted the add-requested-spectres branch February 4, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

2 participants

Comments