Repository navigation
feat(desktop): add a setting to turn the running-terminal close warning back on #8658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { Trans, useLingui } from "@lingui/react/macro"; | ||
| import { Label } from "@superset/ui/label"; | ||
| import { Switch } from "@superset/ui/switch"; | ||
| import { HighlightText } from "renderer/routes/_authenticated/settings/components/HighlightText"; | ||
| import { useSettingsSearchQuery } from "renderer/stores/settings-state"; | ||
| import { useTerminalCloseConfirmStore } from "renderer/stores/terminal-close-confirm/store"; | ||
|
|
||
| export function CloseConfirmSetting() { | ||
| const { t } = useLingui(); | ||
| const searchQuery = useSettingsSearchQuery(); | ||
| const suppressed = useTerminalCloseConfirmStore((state) => state.suppressed); | ||
| const suppress = useTerminalCloseConfirmStore((state) => state.suppress); | ||
| const reset = useTerminalCloseConfirmStore((state) => state.reset); | ||
|
|
||
| return ( | ||
| <div className="flex items-center justify-between gap-10"> | ||
| <div className="space-y-1"> | ||
| <Label htmlFor="terminal-close-confirm" className="text-sm font-medium"> | ||
| <HighlightText | ||
| text={t({ | ||
| message: "Warn before closing a running terminal", | ||
| })} | ||
| query={searchQuery} | ||
| /> | ||
| </Label> | ||
| <p className="text-xs text-muted-foreground max-w-md leading-relaxed"> | ||
| <Trans> | ||
| Ask before you close a terminal, tab, or port that still has a | ||
| process running in it | ||
| </Trans> | ||
| </p> | ||
| </div> | ||
| <Switch | ||
| id="terminal-close-confirm" | ||
| checked={!suppressed} | ||
| onCheckedChange={(checked) => (checked ? reset() : suppress())} | ||
| className="shrink-0" | ||
| /> | ||
| </div> | ||
| ); | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2573,6 +2573,9 @@ msgstr "Minta agen membuat dokumen desain atau laporan. Agen membuat halamannya | |
| msgid "Ask an agent to publish one from the desktop app." | ||
| msgstr "Minta agen untuk memublikasikan satu dari aplikasi desktop." | ||
|
|
||
| msgid "Ask before you close a terminal, tab, or port that still has a process running in it" | ||
| msgstr "Tanyakan sebelum menutup terminal, tab, atau port yang masih menjalankan proses" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Clarify that a process uses the port. The current translation says that a port runs a process. The process uses the port. Consider: “Minta konfirmasi sebelum menutup terminal atau tab yang memiliki proses aktif, atau port yang masih digunakan oleh proses.” The PR objective says this warning also covers ports in use. 🤖 Prompt for AI Agents |
||
|
|
||
| msgid "Ask for approval" | ||
| msgstr "Minta persetujuan" | ||
|
|
||
|
|
@@ -18925,6 +18928,9 @@ msgstr "Membangunkan workspace" | |
| msgid "Want something sooner? <0>Tell us in Discord</0>. Much of what's here started as a user request." | ||
| msgstr "Ingin sesuatu lebih cepat? <0>Beri tahu kami di Discord</0>. Banyak yang ada di sini bermula dari permintaan pengguna." | ||
|
|
||
| msgid "Warn before closing a running terminal" | ||
| msgstr "Peringatkan sebelum menutup terminal yang sedang berjalan" | ||
|
|
||
| msgid "Warning" | ||
| msgstr "Warning" | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2573,6 +2573,9 @@ msgstr "Chiedi a un agente un documento di design o un report. Crea la pagina e | |
| msgid "Ask an agent to publish one from the desktop app." | ||
| msgstr "Chiedi a un agente di pubblicarne una dall'app desktop." | ||
|
|
||
| msgid "Ask before you close a terminal, tab, or port that still has a process running in it" | ||
| msgstr "Chiedi prima di chiudere un terminale, una scheda o una porta in cui è ancora in esecuzione un processo" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Clarify that the port is in use. The current wording says a process is running “in” a port. Translate the port case as “una porta ancora in uso,” or separate it from the terminal and tab cases. The PR objective states that the warning also covers ports in use. 🤖 Prompt for AI Agents |
||
|
|
||
| msgid "Ask for approval" | ||
| msgstr "Chiedi approvazione" | ||
|
|
||
|
|
@@ -18925,6 +18928,9 @@ msgstr "Riattivazione del workspace" | |
| msgid "Want something sooner? <0>Tell us in Discord</0>. Much of what's here started as a user request." | ||
| msgstr "Vuoi qualcosa prima? <0>Dicci la tua su Discord</0>. Molto di ciò che c'è qui è nato da una richiesta degli utenti." | ||
|
|
||
| msgid "Warn before closing a running terminal" | ||
| msgstr "Avvisa prima di chiudere un terminale in esecuzione" | ||
|
|
||
| msgid "Warning" | ||
| msgstr "Avviso" | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Distinguish processes in terminals from processes using ports.
The French text says a process runs “dans” a port. A port is used by a process; it does not contain one. Clarify that terminals and tabs contain processes, while processes use ports.
Proposed translation
📝 Committable suggestion
🤖 Prompt for AI Agents