[saddlepaddle]

Fixes the three issues the Linux QA pass found on #7964. Report and re-test: https://app.superset.sh/page/linux-desktop-header-chrome-qa-pr-7964-92j3dg

• Controls shifted 44px when the sidebar collapsed (Windows/Linux only). The app menu sat inside the expanded header but after the 52px rail when collapsed. It now owns a rail-width slot at the left in both states, in the expanded header and in the rail's top strip, so the toggle and back/forward start at the same x. The row's top offset is also pinned on every platform, not just macOS.
• Settings had no app menu on Windows/Linux. This predates Every screen draws its own headers; the collapsed sidebar keeps the window controls in one band #7964. It now shows in the same slot.
• The record side header ran its primary action under the window controls. The 372px side column can't hold link/ID/⋯, "Create workspace" and Linux's ~97px of window controls. The side header's actions are now a container, and "Create workspace" / "Go to workspace" drop to an icon (keeping an aria-label) only below 18rem of free space. macOS, with no inset, keeps the full label.

Verified

• Linux: dev build of this branch on Xvfb and openbox, with real screen captures and CDP measurements. Toggle, back and forward sit at identical positions expanded vs collapsed (x 68/102/130, y 23) on Tasks, a task, a workspace and Settings. The app menu is at (26,23) everywhere, and a real click opens the native menu. "Create workspace" ends at x=1319, 24px clear of the controls (which start at x=1343); before, it overlapped them by 13px. 0 console errors.
• macOS (dev app, CDP): all 36 screen × sidebar-state rows unchanged (icons at x 88/122/150, y 23), and both action labels still visible (355px of room).
• Checks: lint, typecheck, i18n (no new strings) and 6,287 renderer tests pass.

Not covered: Windows (no Windows host to test on). The logic is the same as Linux's, except its window controls are wider.

---

Summary by cubic

Fixes three issues from the Linux QA pass: the controls shift 44px when the sidebar collapses, Settings lacks an app menu, and record actions run under the window controls.

Bug Fixes

• The app menu now owns a rail-width slot at the left of the header in both expanded and collapsed states, so the toggle and back/forward buttons start at the same x; the top offset is also pinned on every platform, not just macOS.
• Settings now shows the app menu on Windows/Linux in the same slot.
• Record side headers wrap the actions in a container, and "Create workspace"/"Go to workspace" collapse to their icon (keeping an aria-label) only when the header can't fit them; macOS keeps the full labels.

^{Written for commit 746b7cd. Summary will update on new commits.}

Summary by CodeRabbit

• Accessibility
  • Added accessible labels to the “Go to workspace” and “Create workspace” buttons.
• User Interface
  • When action areas are narrow, the workspace buttons hide their text while keeping the arrow icon visible.
  • Adjusted app menu placement and window-control spacing across desktop platforms, including sidebar layouts and window zoom levels.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 3ec33908-97a1-4829-97d6-121a172e07c9

📥 Commits

Reviewing files that changed from the base of the PR and between 27013c2 and 746b7cd.

📒 Files selected for processing (6)

• apps/desktop/src/renderer/routes/_authenticated/_dashboard/cloud-workspaces/$workspaceId/components/CloudWorkspaceRecordView/components/CloudWorkspaceRecordActions/CloudWorkspaceRecordActions.tsx
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarHeader/DashboardSidebarHeader.tsx
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/RecordLayout/RecordLayout.tsx
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/WindowChrome/WindowChrome.tsx
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/tasks/$taskId/components/TaskRecordView/components/TaskRecordActions/TaskRecordActions.tsx
• apps/desktop/src/renderer/routes/_authenticated/settings/components/SettingsSidebar/SettingsSidebar.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The dashboard and settings sidebars now place the app menu in the window-controls band on non-macOS platforms. Workspace record-action buttons gain accessible labels and hide their visible text when the container is narrower than 18rem.

Changes

Sidebar app-menu placement

Layer / File(s)	Summary
Dashboard window controls and menu placement apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/WindowChrome/WindowChrome.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarHeader/DashboardSidebarHeader.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/RecordLayout/RecordLayout.tsx	The dashboard removes the non-macOS app menu from WindowChrome and renders it in the sidebar header. The header adjusts control-band spacing. The side-header uses a flexible drag region before its right-aligned content.
Settings sidebar menu placement apps/desktop/src/renderer/routes/_authenticated/settings/components/SettingsSidebar/SettingsSidebar.tsx	The settings header replaces the non-macOS drag area with an app menu in a container sized to the collapsed workspace sidebar width. macOS retains its 96px drag area.

Responsive workspace actions

Layer / File(s)	Summary
Accessible labels and responsive button text apps/desktop/src/renderer/routes/_authenticated/_dashboard/cloud-workspaces/$workspaceId/components/CloudWorkspaceRecordView/components/CloudWorkspaceRecordActions/CloudWorkspaceRecordActions.tsx, apps/desktop/src/renderer/routes/_authenticated/_dashboard/tasks/$taskId/components/TaskRecordView/components/TaskRecordActions/TaskRecordActions.tsx	The “Go to workspace” and “Create workspace” buttons gain accessible labels. Their visible text is hidden when the record-actions container is narrower than 18rem.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 746b7

The changed controls and responsive actions preserve their documented behavior; remaining platform validation does not identify a specific merge-blocking failure.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 6 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main changes: consistent app-menu placement on Windows/Linux and record actions that fit beside window controls.
Description check	✅ Passed	The description explains all three fixes and includes detailed Linux and macOS validation results, passed checks, and the limitation that Windows was not tested. It omits the template’s explicit Check…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch

Thank you for your contribution! 🎉