Repository navigation
fix(mobile): theme markdown table body rows in the PR description - #6639
Conversation
The description's MarkdownStyle set the table header, border and text for dark mode but not the body row backgrounds, so the library defaults (#FFFFFF / #F9FAFB) leaked through under near-white text. Rows now sit on the app background, matching the chat markdown table.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates the description markdown style. Even and odd table rows now use the dark theme background color. ChangesTable Row Styling
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change themes markdown table body rows for dark mode without changing table structure or behavior; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Problem
Markdown tables in the mobile PR description rendered with white body rows and near-white text on the dark theme — every other row looked empty, the rest barely legible.
DESCRIPTION_MARKDOWN_STYLEthemed the table header, border and text but never set the body row backgrounds, soreact-native-enriched-markdown's defaults leaked through (even rows#FFFFFF, odd rows#F9FAFB).Fix
Set
rowEvenBackgroundColor/rowOddBackgroundColortoTHEME.dark.background— the same flat-row treatment the chat markdown table (MESSAGE_MARKDOWN_STYLE) already uses. Border width, radius and cell padding stay at the library defaults, which already match the chat style.Verified
Rendered
PullRequestDescriptionwith PR #6635's body on the iPhone 16e simulator via a temporary Storybook story: all nine provider rows readable on dark,secondaryheader, 1px border. Before/after: https://claude.ai/code/artifact/d8799837-7ab8-4e3b-9964-0d65ce8c29cbSummary by cubic
Fixes unreadable markdown table body rows in the mobile PR description on dark theme by theming the body backgrounds. Previously
react-native-enriched-markdowndefaults set even rows to #FFFFFF and odd to #F9FAFB against near-white text; now both useTHEME.dark.background, matching chat table styling.Review/QA
rowEvenBackgroundColorandrowOddBackgroundColorinDESCRIPTION_MARKDOWN_STYLE; header/border/text remain as before.Written for commit b9b3993. Summary will update on new commits.
Summary by CodeRabbit