Skip to content

fix(mobile): theme markdown table body rows in the PR description - #6639

Merged
saddlepaddle merged 1 commit into
mainfrom
mobile-diff-table-style
Aug 18, 2026
Merged

saddlepaddle merged 1 commit into
mainfrom
mobile-diff-table-style

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Aug 18, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Markdown tables in the mobile PR description rendered with white body rows and near-white text on the dark theme — every other row looked empty, the rest barely legible.

DESCRIPTION_MARKDOWN_STYLE themed the table header, border and text but never set the body row backgrounds, so react-native-enriched-markdown's defaults leaked through (even rows #FFFFFF, odd rows #F9FAFB).

Fix

Set rowEvenBackgroundColor / rowOddBackgroundColor to THEME.dark.background — the same flat-row treatment the chat markdown table (MESSAGE_MARKDOWN_STYLE) already uses. Border width, radius and cell padding stay at the library defaults, which already match the chat style.

Verified

Rendered PullRequestDescription with PR #6635's body on the iPhone 16e simulator via a temporary Storybook story: all nine provider rows readable on dark, secondary header, 1px border. Before/after: https://claude.ai/code/artifact/d8799837-7ab8-4e3b-9964-0d65ce8c29cb


Summary by cubic

Fixes unreadable markdown table body rows in the mobile PR description on dark theme by theming the body backgrounds. Previously react-native-enriched-markdown defaults set even rows to #FFFFFF and odd to #F9FAFB against near-white text; now both use THEME.dark.background, matching chat table styling.

Review/QA

  • Change: set rowEvenBackgroundColor and rowOddBackgroundColor in DESCRIPTION_MARKDOWN_STYLE; header/border/text remain as before.
  • Scope: affects PR description tables in dark theme only; no API or prop changes; border radius/width and cell padding remain library defaults.
  • Verify: open a PR description with a markdown table in dark mode; body rows sit on the app background, header uses secondary, 1px border, and text is readable.

Written for commit b9b3993. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Style
    • Improved pull request description tables with consistent dark-theme background colors for alternating rows.

The description's MarkdownStyle set the table header, border and text
for dark mode but not the body row backgrounds, so the library defaults
(#FFFFFF / #F9FAFB) leaked through under near-white text. Rows now sit
on the app background, matching the chat markdown table.
@coderabbitai

coderabbitai Bot commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 050d764d-8f6b-4bdf-9c36-8146699d9a68

📥 Commits

Reviewing files that changed from the base of the PR and between 239cf21 and b9b3993.

📒 Files selected for processing (1)
  • apps/mobile/screens/(authenticated)/workspace/[id]/pull-request/[pullRequestId]/components/PullRequestDescription/constants.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The pull request updates the description markdown style. Even and odd table rows now use the dark theme background color.

Changes

Table Row Styling

Layer / File(s) Summary
Markdown table row colors
apps/mobile/screens/.../PullRequestDescription/constants.ts
DESCRIPTION_MARKDOWN_STYLE assigns the dark theme background to even and odd table rows.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to b9b39

This localized change themes markdown table body rows for dark mode without changing table structure or behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title uses conventional commit format and clearly identifies the mobile dark-theme Markdown table row fix.
Description check ✅ Passed The description explains the problem, fix, scope, and verification, and includes a screenshot link; checklist status is not explicitly recorded.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mobile-diff-table-style

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@saddlepaddle
saddlepaddle merged commit 17b9db8 into main Aug 18, 2026
19 of 20 checks passed
@saddlepaddle
saddlepaddle deleted the mobile-diff-table-style branch August 18, 2026 22:16

This branch was previously deployed

1 inactive deployment
preview — b9b39936 Deployed Aug 18, 2026 by saddlepaddle via Deploy API #8064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant