Skip to content

fix(mobile): drop the newline button from the home composer's bottom row - #6600

Merged
saddlepaddle merged 1 commit into
mainfrom
remove-enter-button
Aug 18, 2026
Merged

saddlepaddle merged 1 commit into
mainfrom
remove-enter-button

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Aug 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • fix(mobile): move the newline button into the quick-key row #6543 moved the newline button into the terminal's quick-key row but left a fallback copy in the composer's bottom toolbar for surfaces without that row, so the home composer still showed a ↵ button next to +.
  • Removes that fallback (newlineButton) and its slot. The terminal's newlineChip in the quick-key row is unchanged.

Test plan

  • Biome clean; mobile typecheck has the same 135 pre-existing errors with and without this change, none in GlassComposer.
  • Home composer: expand it — bottom row is +, agent picker, mic/send. No ↵.
  • Terminal composer: ↵ chip still pinned left of the quick keys and still appends a newline.

Summary by cubic

Removes the fallback newline button from the home composer’s bottom row in GlassComposer so only the terminal’s quick-key newline chip remains. Previously, the home composer showed a ↵ button beside +; now it does not. The terminal composer is unchanged.

  • Home composer: bottom row shows +, agent picker, mic/send; no ↵; no API changes.
  • Terminal composer: newlineChip in the quick-key row still inserts a newline.

Written for commit 73b4c2c. Summary will update on new commits.

Review in cubic

#6543 moved the newline button into the terminal's quick-key row but left
a fallback copy in the bottom toolbar for surfaces without that row, so the
home composer still showed a return button beside the attachment button.
It was never meant to sit there: it reads as a send-adjacent action, and
the home prompt gets no more from a line break than a plain paragraph
does. Remove the fallback and its variant; the terminal chip stays.
@saddlepaddle
saddlepaddle merged commit fdc98c4 into main Aug 18, 2026
10 of 11 checks passed
@saddlepaddle
saddlepaddle deleted the remove-enter-button branch August 18, 2026 02:45
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@saddlepaddle, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Limit details: You’ve used all 10 included reviews currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c7a937d6-6abd-406f-82f7-38751cc4155f

📥 Commits

Reviewing files that changed from the base of the PR and between 338c64c and 73b4c2c.

📒 Files selected for processing (1)
  • apps/mobile/screens/(authenticated)/components/GlassComposer/GlassComposer.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

🚀 Preview Deployment

🔗 Preview Links

Service Status Link
Neon Database (Neon) ✅ View Branch
Vercel API (Vercel) ✅ Open Preview
Vercel Web (Vercel) ✅ Open Preview
Vercel Marketing (Vercel) ✅ Open Preview
Vercel Admin (Vercel) ✅ Open Preview
Vercel Docs (Vercel) ✅ Open Preview

Preview updates automatically with new commits

This branch was previously deployed

1 inactive deployment
preview — 73b4c2ce Deployed Aug 18, 2026 by saddlepaddle via Deploy Web #7969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant