Repository navigation
fix(mobile): move the newline button into the quick-key row - #6543
Conversation
It sat in the composer's bottom row beside the attachment button, where it reads as a send-adjacent action. It belongs with esc/tab/arrows — the keys the soft keyboard lacks — so it moves into that row, shaped like them rather than like the circular send and mic buttons. Pinned left of the scrolling keys so it stays reachable however far they are scrolled, and it is not a quick key itself: those write raw bytes to the PTY, while this appends to the draft. Surfaces with no key row (the home composer) keep it in the bottom row.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe composer adds a compact newline chip beside ChangesGlassComposer newline controls
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🔵 Low · up to The newline control is moved into the quick-key row, but longer key sets may not scroll within a bounded viewport, potentially affecting reachability of the pinned newline control. The PR is mergeable with explicit owner awareness or a follow-up layout fix. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
…row (#6600) #6543 moved the newline button into the terminal's quick-key row but left a fallback copy in the bottom toolbar for surfaces without that row, so the home composer still showed a return button beside the attachment button. It was never meant to sit there: it reads as a send-adjacent action, and the home prompt gets no more from a line break than a plain paragraph does. Remove the fallback and its variant; the terminal chip stays.
The newline button sat in the composer's bottom row beside the attachment button, where it reads as a send-adjacent action. It belongs with
esc/tab/ arrows — the keys the soft keyboard doesn't have.+escThree details:
QUICK_KEYS, which would have sent a carriage return to the terminal and submitted instead of inserting a line break.Surfaces with no key row — the home composer — keep it in the bottom row, since there's nothing else to put it with.
Typecheck and lint pass. Not exercised on a simulator; it's a layout move within an existing SwiftUI stack, but worth a glance on device before merge if you want certainty.
Summary by cubic
Moves the newline button from the composer’s bottom row (next to the attachment button) into the quick-key row beside esc. This clarifies that it inserts a line break rather than a send-adjacent action; surfaces without a key row keep it in the bottom row.
Written for commit 97a2ad3. Summary will update on new commits.
Summary by CodeRabbit
New Features
Improvements