Repository navigation
fix(desktop): use <output> for the auto-resume status text so Lint passes on main - #6590
saddlepaddle wants to merge 1 commit into
Conversation
…SemanticElements) main has failed the Lint job since #6572: biome flags <span role="status"> and asks for the semantic element. <output> carries the status role implicitly.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe terminal auto-resume status message now uses an ChangesTerminal auto-resume
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a localized markup-only accessibility and lint fix with no intended behavior change; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR has had no activity for 53 days and will close in 7 days unless there is new activity. If this contribution is still important or relevant, please leave a comment to keep it open. If it closes, you are welcome to reopen it or ask a maintainer to reopen it. Thank you for contributing! |
|
This PR was automatically closed due to inactivity to help keep the review queue manageable. This does not mean the contribution was rejected. If this contribution is still important or relevant, please reopen it or leave a comment asking a maintainer to reopen it. Thank you for contributing! |
Summary
mainhas failed the CI Lint job since feat(desktop,host-service): auto-resume interrupted agent sessions idempotently #6572: biomelint/a11y/useSemanticElementsflags<span role="status">inTerminalAgentAutoResume.tsxand asks for the semantic element. Swap it for<output>, which carries thestatusrole implicitly. Same classes, samearia-live, no behaviour change.Testing
bunx @biomejs/biome@2.4.2 check <file>(the CI-pinned version) — clean.Summary by cubic
Fixes the failing CI Lint on
mainby replacing the auto-resume status text element. Previously used<span role="status">; now uses<output>which impliesrole="status". No UI or behavior change.TerminalAgentAutoResume.tsxto satisfy Biomelint/a11y/useSemanticElements.aria-live="polite"and classes; status announcements remain the same.@biomejs/biome@2.4.2; unblocks red Lint checks on merge refs for all PRs.Written for commit c28f0d2. Summary will update on new commits.
Summary by CodeRabbit