Skip to content

fix(desktop): use <output> for the auto-resume status text so Lint passes on main - #6590

Closed
saddlepaddle wants to merge 1 commit into
mainfrom
fix-auto-resume-status-lint
Closed

saddlepaddle wants to merge 1 commit into
mainfrom
fix-auto-resume-status-lint

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Aug 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • main has failed the CI Lint job since feat(desktop,host-service): auto-resume interrupted agent sessions idempotently #6572: biome lint/a11y/useSemanticElements flags <span role="status"> in TerminalAgentAutoResume.tsx and asks for the semantic element. Swap it for <output>, which carries the status role implicitly. Same classes, same aria-live, no behaviour change.
  • Because CI lints each PR's merge ref, this one line is currently turning every open PR's Lint check red.

Testing

  • bunx @biomejs/biome@2.4.2 check <file> (the CI-pinned version) — clean.

Summary by cubic

Fixes the failing CI Lint on main by replacing the auto-resume status text element. Previously used <span role="status">; now uses <output> which implies role="status". No UI or behavior change.

  • Updates TerminalAgentAutoResume.tsx to satisfy Biome lint/a11y/useSemanticElements.
  • Keeps aria-live="polite" and classes; status announcements remain the same.
  • Verified clean with @biomejs/biome@2.4.2; unblocks red Lint checks on merge refs for all PRs.

Written for commit c28f0d2. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Accessibility
    • Updated the terminal agent resume status message to use a semantic output element while preserving its live updates, styling, and displayed text.

…SemanticElements)

main has failed the Lint job since #6572: biome flags <span role="status"> and
asks for the semantic element. <output> carries the status role implicitly.
@coderabbitai

coderabbitai Bot commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a1cd60c0-7579-403b-87d6-8763ad59aa9a

📥 Commits

Reviewing files that changed from the base of the PR and between a2acf8f and c28f0d2.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/components/TerminalAgentAutoResume/TerminalAgentAutoResume.tsx

Included review availability: Your plan includes up to 10 reviews per rolling hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The terminal auto-resume status message now uses an <output> element instead of a <span role="status">. Its live-region behavior, styling, and displayed messages remain unchanged.

Changes

Terminal auto-resume

Layer / File(s) Summary
Replace resume status element
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/components/TerminalAgentAutoResume/TerminalAgentAutoResume.tsx
The status message uses <output> with the existing polite live announcement, styling, and resume or failure text.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to c28f0

This is a localized markup-only accessibility and lint fix with no intended behavior change; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: kitenite

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title uses conventional commit format and clearly describes replacing the status element to fix the lint failure.
Description check ✅ Passed The description explains the change, its purpose, preserved behavior, and the lint command used for testing.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-auto-resume-status-lint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

This PR has had no activity for 53 days and will close in 7 days unless there is new activity. If this contribution is still important or relevant, please leave a comment to keep it open. If it closes, you are welcome to reopen it or ask a maintainer to reopen it. Thank you for contributing!

@github-actions github-actions Bot added the stale label Oct 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR was automatically closed due to inactivity to help keep the review queue manageable. This does not mean the contribution was rejected. If this contribution is still important or relevant, please reopen it or leave a comment asking a maintainer to reopen it. Thank you for contributing!

@github-actions github-actions Bot closed this Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant