Repository navigation
refactor(api): remove v1 MCP server (relanded on main) - #6082
Merged
Merged
Conversation
Removes packages/mcp (18 tools), the /api/agent route and its parallel 274-line auth flow, the workspace dep, and the v1 OAuth audience. v1 URLs now return 410 Gone pointing at /api/v2/agent/mcp. Remaining v1 traffic is desktop builds predating the chat runtime change, which degrade gracefully (chat loses Superset tools, no crash); the 410 also ends the 800-second SSE timeout invocations v1 clients were causing. Claude-Session: https://claude.ai/code/session_01Kub4p3Eim9pc1qaRRmGea2 (cherry picked from commit 3c570f6)
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (53)
💤 Files with no reviewable changes (50)
📝 WalkthroughWalkthroughThe PR removes the legacy MCP v1 package and request handling. The v1 endpoint now returns ChangesMCP v1 retirement
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Ready to review this PR? Stage has broken it down into 5 individual chapters for you:
Chapters generated by Stage for commit cba60b2 on Jul 31, 2026 11:43pm UTC. |
Contributor
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relands #6077, which was accidentally merged into its stale base branch (
mcp-rework/0g-slack-v1-retire) instead of main — GitHub didn't retarget because that branch was never deleted after #6076's squash-merge. Clean cherry-pick of the same commit onto current main.Same content as #6077:
packages/mcp(v1, 18 tools),apps/api/src/app/api/agent/route + 274-lineauth-flow.ts, the@superset/mcpdep, and the v1 OAuth audience entry./api/agent/*returns 410 Gone with a hint pointing at the current MCP URL.See #6077 for the original review context (traffic analysis, graceful-degradation reasoning for old desktop chat builds).
https://claude.ai/code/session_01Kub4p3Eim9pc1qaRRmGea2
Summary by cubic
Removed the legacy v1 MCP server and route. v1 URLs now return 410 Gone with a hint to
/api/v2/agent/mcp; docs and OpenAPI now describe v2 only.Refactors
packages/mcp(18 tools) and the v1 auth/route (apps/api/src/app/api/agent/[transport]/*)./api/agent/*handlers with a JSON 410 pointing to${NEXT_PUBLIC_API_URL}/api/v2/agent/mcp.@superset/mcpfromapps/api/package.jsonand prunedbun.lock.@superset/authconfig.apps/docs/content/docs/mcp-server.mdxto mark v1 removed.Migration
${NEXT_PUBLIC_API_URL}/api/v2/agent/mcp. No other changes needed.Written for commit cba60b2. Summary will update on new commits.
Summary by CodeRabbit
Breaking Changes
410 Gone.Documentation