Repository navigation
chore(api): retire SLACK_MCP_V2 flag and v1 Slack MCP path - #6076
Conversation
All Slack agent traffic has been on the v2 in-memory client; the flag fork, the v1 client factory, and the dual-shape context parsing were dead weight blocking v1 MCP removal. Claude-Session: https://claude.ai/code/session_01Kub4p3Eim9pc1qaRRmGea2
|
Ready to review this PR? Stage has broken it down into 4 individual chapters for you:
Chapters generated by Stage for commit f163922 on Jul 31, 2026 9:07pm UTC. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe Slack agent now uses MCP v2 directly. Feature-flag selection, legacy client setup, v1 tool handling, and the ChangesSlack MCP v2 standardization
API app repository hygiene
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant SlackAgent
participant SupersetMcpClient
participant SupersetTools
SlackAgent->>SupersetMcpClient: Create standard MCP v2 client
SupersetMcpClient->>SupersetTools: Request organization members, task statuses, and hosts
SupersetTools-->>SlackAgent: Return v2 context responses
SlackAgent->>SlackAgent: Parse hosts_list result and filter denied tools
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Part of the MCP v2 rework (Phase 0g) — prerequisite for v1 MCP server removal (the Slack v1 path was the last importer of
@superset/mcpoutside the v1 route itself).slack-mcp-v2flag read, the v1 client factory,DENIED_SUPERSET_TOOLS_V1, and everyuseV2fork (tool names, hosts/devices response parsing) are deleted.createSupersetMcpV2Clientis renamed tocreateSupersetMcpClientnow that it's the only one.SLACK_MCP_V2removed from shared feature-flag constants. The PostHog flag (id 668461) is now unread; it can be archived in PostHog as housekeeping — no flag flip needed since the code no longer consults it.All observed Slack MCP traffic (60d PostHog) was already v2.
https://claude.ai/code/session_01Kub4p3Eim9pc1qaRRmGea2
Summary by cubic
Retires Slack MCP v1 and the
SLACK_MCP_V2flag. The Slack agent now always uses the v2 in-memory MCP client to simplify the code and unblock v1 server removal.@superset/mcp-v2/in-memoryonly; delete v1 client and all v1/v2 branches.createSupersetMcpV2ClienttocreateSupersetMcpClient.SLACK_MCP_V2from@superset/sharedand stop reading the PostHog flag (safe to archive).organization_members_list,tasks_statuses_list,hosts_list(and v2hosts_listresult shape)..verceltoapps/api/.gitignore.Written for commit f163922. Summary will update on new commits.
Summary by CodeRabbit
New Features
Bug Fixes
Chores