Repository navigation
AI review fixes for #3951 - #4051
Merged
Merged
Conversation
- openc3/lib/openc3/topics/topic.rb:74 - SonarQube rubydre:S7865: replaced ENV['OPENC3_STREAM_MAX_AGE_SECONDS'] with ENV.fetch('OPENC3_STREAM_MAX_AGE_SECONDS', nil). Behaviour is unchanged: nil still selects the default.
- openc3/python/openc3/topics/topic.py:121 - SonarQube python:S5806: stopped reassigning the builtin-shadowing `id` and decode into a local `entry_id` instead. The parameter name stays `id`, so positional callers and parity with Ruby are unaffected.
- openc3/python/test/topics/test_topic.py:36,41,60,64,87 - SonarQube python:S8997: replaced direct os.environ assignments with scoped `with patch.dict(os.environ, {...})` blocks. pytest's monkeypatch can't be used in a unittest.TestCase. Every assertion is kept.
AI-Review-Bot: true
AI-Review-Run: 38335348590
ryanmelt
approved these changes
Oct 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/stream-safety-trim #4051 +/- ##
===========================================================
- Coverage 80.30% 80.23% -0.07%
===========================================================
Files 901 901
Lines 68777 68752 -25
Branches 2665 2714 +49
===========================================================
- Hits 55229 55162 -67
- Misses 12882 12921 +39
- Partials 666 669 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the AI review of #3951 at 472b87b. Merge this PR to apply them to
feat/stream-safety-trim; the full review summary is on #3951.What changed
fix(review): apply Claude review fixes (turn 1)
idand decode into a localentry_idinstead. The parameter name staysid, so positional callers and parity with Ruby are unaffected.with patch.dict(os.environ, {...})blocks. pytest's monkeypatch can't be used in a unittest.TestCase. Every assertion is kept.