[19.0][MIG] contract_line_successor by bosd · Pull Request #1370 · OCA/contract

bosd · 2025-12-29T23:22:25Z

Standard migration using odoo-module-migrator /ocabot migration contract_line_successor .

CRogos

Code review LGTM, but not tested because runboat not available. Maybe rebase?

Some of the commits should also be squashed.

MohamedOsman7 · 2026-05-06T12:16:17Z

@bosd Are you still working on this? Please check #1370 (review)

bosd · 2026-05-08T11:33:50Z

@bosd Are you still working on this? Please check #1370 (review)

No not actively. we use it in production. the commit you mention is a nice to have. no functional impact.
This branch is currentlly blocked by not having the base module merged.
@MohamedOsman7 Can you please leave a review, to keep progress on this pr.

MohamedOsman7 · 2026-05-13T10:38:41Z

@@ -818,15 +834,16 @@ def cron_renew_contract_line(self):

    def unlink(self):


@bosd Is this function still necessary if validation is no longer needed here?

@bosd

@bosd Is this function still necessary if validation is no longer needed here?

You're right — removed it. With the validation gone, the override only called super().unlink(), so it was dead code (and the docstring was stale). test_unlink still passes since the inherited behaviour is identical.

…contract_termination [REF] contract: remove abstract conract model simplify contract definition [IMP] contract: clean UI and improve UX [FIX] contract: fix tour test [IMP] contract: several imp - use Command - mark _update_recurring_next_date deprecated - use list instead of tree [FIX] contract: recurring_next_date is required only if next_period_date_end is set [IMP] contract: contract template inherit from mail thread [IMP] index contract.template product_id [IMP] contract_line_successor: Auto renew interval should be different then 0 [FIX] contract_line_successor: Adding markup to messages [IMP] contract: simplify multi-company ir.rule domain [IMP] contract: remove invisible fields [IMP] contract: use Command new sytnax [FIX] contract: remove useless odoo-modules declaration in js [FIX] contract: use text-end in report

…rror in column_invisible

Currently translated at 100.0% (87 of 87 strings) Translation: contract-18.0/contract-18.0-contract_line_successor Translate-URL: https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-contract_line_successor/it/

bosd · 2026-06-17T06:55:52Z

Updated, thanks @MohamedOsman7 @CRogos:

Removed the no-op unlink override flagged above.
Rebased onto current 19.0 and squashed the [IMP] pre-commit execution commit into [MIG].
The test-requirements.txt pointing at [19.0] [MIG] contract: Migration to 19.0 #1312 is no longer needed — [19.0] [MIG] contract: Migration to 19.0 #1312 is merged, so the base contract module is on 19.0 and the file was dropped. runboat/tests should build now.

MohamedOsman7

LGTM

CRogos

Code review LGTM, but not tested.

OCA-git-bot · 2026-07-03T07:22:11Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

MohamedOsman7 · 2026-07-06T10:31:24Z

@pedrobaeza could you merge?

pedrobaeza · 2026-07-06T10:32:33Z

An extra review from PSC/maintainer is needed.

/ocabot migration contract_line_successor

OCA-git-bot · 2026-07-06T10:32:43Z

The migration issue (#1310) has not been updated to reference the current pull request because a previous pull request (#1334) is not closed.
Perhaps you should check that there is no duplicate work.
CC @Wodran14

bosd mentioned this pull request Dec 29, 2025

[19.0][MIG] contract_refund_on_stop #1369

Open

bosd force-pushed the 19.0-mig-contract_line_successor branch from 492b042 to 4cce567 Compare December 29, 2025 23:44

bosd mentioned this pull request Dec 29, 2025

[19.0][MIG] contract_termination #1367

Open

bosd force-pushed the 19.0-mig-contract_line_successor branch 2 times, most recently from de9c38d to 873410f Compare December 30, 2025 10:28

bosd marked this pull request as ready for review December 30, 2025 10:30

bosd force-pushed the 19.0-mig-contract_line_successor branch from 873410f to 361a5df Compare December 30, 2025 10:30

bosd mentioned this pull request Apr 15, 2026

[19.0][MIG] product_contract #1371

Open

CRogos reviewed Apr 20, 2026

View reviewed changes

bosd force-pushed the 19.0-mig-contract_line_successor branch from 361a5df to e8e5cb0 Compare May 8, 2026 11:34

OCA-git-bot added series:19.0 mod:contract_line_successor Module contract_line_successor labels May 8, 2026

bosd requested a review from CRogos May 8, 2026 11:34

bosd force-pushed the 19.0-mig-contract_line_successor branch from e8e5cb0 to a33b4dd Compare May 12, 2026 15:09

MohamedOsman7 reviewed May 13, 2026

View reviewed changes

Comment thread contract_line_successor/test-requirements.txt Outdated

Larsq1 mentioned this pull request Jun 9, 2026

[19.0][MIG] contract_price_revision #1450

Open

3 tasks

bosd force-pushed the 19.0-mig-contract_line_successor branch 2 times, most recently from f65e04c to 65bf6b8 Compare June 11, 2026 07:16

bosd requested a review from MohamedOsman7 June 11, 2026 08:21

CRogos mentioned this pull request Jun 11, 2026

[19.0][PATCH] contract_line_successor c4a8-odoo/module-oca-contract#16

Open

Larsq1 mentioned this pull request Jun 15, 2026

[19.0][MIG] contract_forecast #1464

Open

5 tasks

sbejaoui and others added 6 commits June 17, 2026 08:54

Added translation using Weblate (Italian)

545c5e6

[FIX] contract_line_succesor: use parent.is_auto_renew to avoid EvalE…

97a3ba6

…rror in column_invisible

Added translation using Weblate (Portuguese (Brazil))

915e074

Translated using Weblate (Italian)

14f2f0b

Currently translated at 100.0% (87 of 87 strings) Translation: contract-18.0/contract-18.0-contract_line_successor Translate-URL: https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-contract_line_successor/it/

Added translation using Weblate (Swedish)

e570fb9

bo-eska and others added 2 commits June 17, 2026 08:54

Added translation using Weblate (Turkish)

f57b294

[MIG] contract_line_successor: Migration to 19.0

6ba8544

bosd force-pushed the 19.0-mig-contract_line_successor branch from 65bf6b8 to 6ba8544 Compare June 17, 2026 06:55

MohamedOsman7 approved these changes Jul 2, 2026

View reviewed changes

CRogos approved these changes Jul 3, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Jul 3, 2026

OCA-git-bot added this to the 19.0 milestone Jul 6, 2026

		@@ -818,15 +834,16 @@ def cron_renew_contract_line(self):

		def unlink(self):

Uh oh!

Uh oh!

Conversation

bosd commented Dec 29, 2025

Uh oh!

CRogos left a comment

Choose a reason for hiding this comment

Uh oh!

MohamedOsman7 commented May 6, 2026

Uh oh!

bosd commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MohamedOsman7 May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MohamedOsman7 Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

bosd Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bosd commented Jun 17, 2026

Uh oh!

MohamedOsman7 left a comment

Choose a reason for hiding this comment

Uh oh!

CRogos left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Jul 3, 2026

Uh oh!

MohamedOsman7 commented Jul 6, 2026

Uh oh!

pedrobaeza commented Jul 6, 2026

Uh oh!

OCA-git-bot commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

bosd commented May 8, 2026 •

edited

Loading

MohamedOsman7 May 13, 2026 •

edited

Loading