[19.0] [MIG] contract: Migration to 19.0 by BhaveshHeliconia · Pull Request #1312 · OCA/contract

BhaveshHeliconia · 2025-10-01T09:21:06Z

No description provided.

tishmen · 2025-10-17T00:35:33Z

@BhaveshHeliconia can you please handle the failing tests so we can push this forward?

mamcode · 2025-10-27T00:28:59Z

@BhaveshHeliconia could you please re-run the CI checks?
I’ve tested locally with the latest ghcr.io/oca/oca-ci:py3.11-19.0 image, and it seems the CI is using an outdated cache because I am getting different errors from unit tests.

BhaveshHeliconia · 2025-11-12T12:11:37Z

@tishmen @mamcode : CI is green now. Thanks!

pedrobaeza · 2025-11-19T15:37:57Z

/ocabot migration contract

Please cherry-pick #1343

BhaveshHeliconia · 2025-11-20T05:04:34Z

/ocabot migration contract

Please cherry-pick #1343

@pedrobaeza : Done. Thanks!

BhaveshHeliconia · 2025-11-21T04:30:07Z

@pedrobaeza : I’ve completed all the changes you recommended. Thanks for the feedback!

pedrobaeza · 2025-11-24T07:29:20Z

Please include #1341

BhaveshHeliconia · 2025-11-25T05:06:21Z

Please include #1341

Done. Thanks!

BhaveshHeliconia · 2026-06-01T05:37:25Z

@carlos-lopez-tecnativa I've solved that issue. Thanks!

bosd · 2026-06-10T19:11:29Z

@carlos-lopez-tecnativa Can we move forward with this one?

carlos-lopez-tecnativa

@BhaveshHeliconia Please check my comment about this commit: 501d387 It seems to be mixing code changes with translation changes.

Everything else looks good. If @pedrobaeza agrees, it can be merged as far as I'm concerned. However, I think the commit mentioned above should be reworked and split into separate commits.

pedrobaeza · 2026-06-10T19:25:48Z

Yes, please, let's fix that commit.

This field slightly degrades performance. We don't need to maintain retro-compatibility with 11- anymore.

Currently translated at 6.6% (17 of 256 strings) Translation: contract-18.0/contract-18.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-contract/sl/

Currently translated at 96.4% (247 of 256 strings) Translation: contract-18.0/contract-18.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-contract/ca/

…upport

Allow to hook contract._prepare_invoice to add more invoice lines

Fix date_ref when invoicing multiple contracts

Currently translated at 92.5% (237 of 256 strings) Translation: contract-18.0/contract-18.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-contract/es/

BhaveshHeliconia · 2026-06-11T04:51:42Z

@carlos-lopez-tecnativa @pedrobaeza I've separated the commit. Could you please check whether it looks correct now?

If there are still any improvements needed, please let me know and I'll address them.

pedrobaeza · 2026-06-11T06:17:30Z

Let's merge it, although the separation is not totally clean, but it's not breaking any real attribution.

/ocabot merge nobump

OCA-git-bot · 2026-06-11T06:17:38Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-1312-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2026-06-11T06:25:42Z

Congratulations, your PR was merged at dde2c0c. Thanks a lot for contributing to OCA. ❤️

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from 877c2f7 to 8f589c2 Compare October 1, 2025 10:12

BhaveshHeliconia force-pushed the 19.0-mig-contract branch 2 times, most recently from b18f362 to 885e5a6 Compare October 8, 2025 12:17

BhaveshHeliconia force-pushed the 19.0-mig-contract branch 5 times, most recently from a38846e to c99f54f Compare October 17, 2025 03:57

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from c99f54f to 983c9c2 Compare October 27, 2025 06:11

BhaveshHeliconia force-pushed the 19.0-mig-contract branch 2 times, most recently from a653227 to 3251a90 Compare November 12, 2025 12:05

OCA-git-bot added this to the 19.0 milestone Nov 19, 2025

OCA-git-bot mentioned this pull request Nov 19, 2025

Migration to version 19.0 #1310

Open

27 tasks

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from 3251a90 to a3218c0 Compare November 20, 2025 05:01

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from a3218c0 to b57bad9 Compare November 20, 2025 05:11

pedrobaeza reviewed Nov 20, 2025

View reviewed changes

Comment thread contract/models/contract_template_line.py Outdated

Comment thread contract/tests/test_contract.py Outdated

Comment thread contract/tests/test_contract.py Outdated

Comment thread contract/tests/test_portal.py Outdated

BhaveshHeliconia force-pushed the 19.0-mig-contract branch 2 times, most recently from 65801a9 to 4ce03c5 Compare November 21, 2025 04:27

pedrobaeza reviewed Nov 21, 2025

View reviewed changes

BhaveshHeliconia force-pushed the 19.0-mig-contract branch 2 times, most recently from b527c46 to 4e377c2 Compare November 21, 2025 09:51

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from 4e377c2 to 8cddba3 Compare November 25, 2025 05:01

BhaveshHeliconia force-pushed the 19.0-mig-contract branch 2 times, most recently from 298d48b to 847b186 Compare June 1, 2026 05:27

carlos-lopez-tecnativa approved these changes Jun 10, 2026

View reviewed changes

OCA-git-bot added the approved label Jun 10, 2026

qgroulard and others added 14 commits June 11, 2026 10:09

[IMP] contract: Remove account.move old_contract_id field

a52093a

This field slightly degrades performance. We don't need to maintain retro-compatibility with 11- anymore.

[I18N] Move translation updates from previous commit

c31e2aa

[FIX] contract: Use another condition for forcingn a failure

fea00f4

Translated using Weblate (Slovenian)

b497f33

Currently translated at 6.6% (17 of 256 strings) Translation: contract-18.0/contract-18.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-contract/sl/

Translated using Weblate (Catalan)

f65e811

Currently translated at 96.4% (247 of 256 strings) Translation: contract-18.0/contract-18.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-contract/ca/

[18.0][IMP] contract: Improve contract lines view with section/note s…

f201c02

…upport

[FIX] contract: improve views

befa5be

[FIX] contract : ignore date constraint for a note

6af2643

[IMP] contract: invoice lines

7b46b35

Allow to hook contract._prepare_invoice to add more invoice lines

[FIX] contract: invoicing

4e97213

Fix date_ref when invoicing multiple contracts

Translated using Weblate (Spanish)

75bc954

Currently translated at 92.5% (237 of 256 strings) Translation: contract-18.0/contract-18.0-contract Translate-URL: https://translation.odoo-community.org/projects/contract-18-0/contract-18-0-contract/es/

[IMP] contract: add monthly_recurring field to contracts and lines

920fba3

[IMP] contract: pre-commit auto fixes

df5d832

[MIG] contract: Migration to 19.0

430fb78

BhaveshHeliconia force-pushed the 19.0-mig-contract branch from 847b186 to 430fb78 Compare June 11, 2026 04:48

OCA-git-bot added the bot is merging ⏳ label Jun 11, 2026

OCA-git-bot merged commit bb61c35 into OCA:19.0 Jun 11, 2026
6 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 11, 2026

Uh oh!

Uh oh!

Conversation

BhaveshHeliconia commented Oct 1, 2025

Uh oh!

tishmen commented Oct 17, 2025

Uh oh!

mamcode commented Oct 27, 2025

Uh oh!

BhaveshHeliconia commented Nov 12, 2025

Uh oh!

pedrobaeza commented Nov 19, 2025

Uh oh!

BhaveshHeliconia commented Nov 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BhaveshHeliconia commented Nov 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pedrobaeza commented Nov 24, 2025

Uh oh!

BhaveshHeliconia commented Nov 25, 2025

Uh oh!

BhaveshHeliconia commented Jun 1, 2026

Uh oh!

bosd commented Jun 10, 2026

Uh oh!

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Jun 10, 2026

Uh oh!

BhaveshHeliconia commented Jun 11, 2026

Uh oh!

pedrobaeza commented Jun 11, 2026

Uh oh!

OCA-git-bot commented Jun 11, 2026

Uh oh!

Uh oh!

OCA-git-bot commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants