Skip to content

Filled in spectator xray#747

Merged
AdamTadeusz merged 8 commits into
NeotokyoRebuild:masterfrom
AdamTadeusz:080_filledInSpectatorXray
Oct 24, 2024
Merged

Filled in spectator xray#747
AdamTadeusz merged 8 commits into
NeotokyoRebuild:masterfrom
AdamTadeusz:080_filledInSpectatorXray

Conversation

@AdamTadeusz

@AdamTadeusz AdamTadeusz commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

Description

-------> New Assets in NeotokyoRebuild/neoAssets#11 <-------

------->Depends on #738<-------

Uses the haloadd_ps20 instead of the haloaddoutline_ps20 shader. Draws twice to get a full outline mostly, a third draw with reduced opacity to fill in the spectated player.

Toolchain

  • Windows MSVC VS2022
  • Linux GCC Distro Native [Specify distro + GCC version]
  • Linux GCC 10 Sniper 3.0

Linked Issues

@AdamTadeusz
AdamTadeusz marked this pull request as draft October 17, 2024 17:04
@AdamTadeusz AdamTadeusz changed the title 080 filled in spectator xray Filled in spectator xray Oct 17, 2024
@AdamTadeusz
AdamTadeusz marked this pull request as ready for review October 17, 2024 17:19
@AdamTadeusz AdamTadeusz added the Changes in neoAssets This PR depends on changes in the neoAssets repository. The relevant PR should be in the description label Oct 17, 2024
@AdamTadeusz
AdamTadeusz requested a review from a team October 17, 2024 17:21
brysondev
brysondev previously approved these changes Oct 17, 2024
@AdamTadeusz

Copy link
Copy Markdown
Contributor Author

@brysondev bro
image

@brysondev

brysondev commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

@brysondev bro

Im blind 🙈

@AdamTadeusz

Copy link
Copy Markdown
Contributor Author

@brysondev bro
image

@brysondev

Copy link
Copy Markdown
Contributor

@brysondev bro image

image
Checkmate

@AdamTadeusz

Copy link
Copy Markdown
Contributor Author

@brysondev bro image

image Checkmate

ahh shit mb

@nullsystem nullsystem added this to the v10.0-prealpha milestone Oct 19, 2024
Rainyan

This comment was marked as resolved.

@kassibuss

Copy link
Copy Markdown
Contributor

Outlined players might be better for spectating yeah

@AdamTadeusz

AdamTadeusz commented Oct 22, 2024

Copy link
Copy Markdown
Contributor Author

Is this the intended appearance?

glow1

It looks a bit strange to me, especially at a distance where it seems the shapes get more "blobby"(?)

glow2

Might prefer the previous outlined version, personally, as I'd like to be able to see the character's textures - although I could see a full body stencil being useful for things like communicating damage, see for example this from CS where they use it as a health bar that pops up contextually (although still with some transparency):

cs

no, should look something like
image

There's one line you have to change for one of the materials, see the linked pr in neoAssets

I was also thinking about either doing a filled in health thing like in cs, or maybe three bars above the player for health, camo and sprint

@Rainyan

Rainyan commented Oct 22, 2024

Copy link
Copy Markdown
Member

Gotcha. I did intend to pull in the other related PR changes as well, but maybe I missed something. Will reinvestigate tomorrow.

@Rainyan
Rainyan self-requested a review October 22, 2024 21:47
@Rainyan

Rainyan commented Oct 23, 2024

Copy link
Copy Markdown
Member

@AdamTadeusz Could you please rebase/resolve this on top of current master when you have the time, as there's currently a merge conflict with the recently merged #738 (which this PR depends on)

@AdamTadeusz

Copy link
Copy Markdown
Contributor Author

@Rainyan mb, should work now

@AdamTadeusz
AdamTadeusz requested a review from brysondev October 23, 2024 14:27

@Rainyan Rainyan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever bug I had earlier with the shaders seems fixed now - I probably did something wrong the first time when merging in the assets. Looks good!

@AdamTadeusz
AdamTadeusz merged commit 762398a into NeotokyoRebuild:master Oct 24, 2024
@AdamTadeusz
AdamTadeusz deleted the 080_filledInSpectatorXray branch January 24, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes in neoAssets This PR depends on changes in the neoAssets repository. The relevant PR should be in the description

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants