Filled in spectator xray#747
Merged
AdamTadeusz merged 8 commits intoOct 24, 2024
Merged
Conversation
AdamTadeusz
marked this pull request as draft
October 17, 2024 17:04
AdamTadeusz
marked this pull request as ready for review
October 17, 2024 17:19
brysondev
previously approved these changes
Oct 17, 2024
Contributor
Author
|
@brysondev bro |
Contributor
Im blind 🙈 |
Contributor
Author
|
@brysondev bro |
Contributor
|
Contributor
Author
ahh shit mb |
Contributor
|
Outlined players might be better for spectating yeah |
Contributor
Author
Member
|
Gotcha. I did intend to pull in the other related PR changes as well, but maybe I missed something. Will reinvestigate tomorrow. |
Rainyan
self-requested a review
October 22, 2024 21:47
Member
|
@AdamTadeusz Could you please rebase/resolve this on top of current master when you have the time, as there's currently a merge conflict with the recently merged #738 (which this PR depends on) |
Contributor
Author
|
@Rainyan mb, should work now |
brysondev
approved these changes
Oct 23, 2024
Rainyan
approved these changes
Oct 23, 2024
Rainyan
left a comment
Member
There was a problem hiding this comment.
Whatever bug I had earlier with the shaders seems fixed now - I probably did something wrong the first time when merging in the assets. Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Description
-------> New Assets in NeotokyoRebuild/neoAssets#11 <-------
------->Depends on #738<-------
Uses the haloadd_ps20 instead of the haloaddoutline_ps20 shader. Draws twice to get a full outline mostly, a third draw with reduced opacity to fill in the spectated player.
Toolchain
Linked Issues