Spectator xray toggled off on spawn, fixes to how outline is drawn#738
Merged
AdamTadeusz merged 8 commits intoOct 22, 2024
Merged
Conversation
Contributor
Author
|
player weapons still aren't outlined when players are cloaked, overriding the material before each attachment is drawn seems to not fix it, don't want to really mess with the base DrawModel functions |
Rainyan
requested changes
Oct 16, 2024
Rainyan
left a comment
Rainyan
left a comment
Member
There was a problem hiding this comment.
Apologies about the similar note spam, GitHub gets janky when trying to annotate code across wide ranges for the review.
Contributor
Author
|
@Rainyan Ok ill stop adding stuff now, the filled in thinner spectator outline can go in a separate pr. It needs a neoAssets pr anyway |
AdamTadeusz
changed the title
Rainyan
previously approved these changes
Oct 22, 2024
brysondev
approved these changes
Oct 22, 2024
Rainyan
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-overrides the material used to draw player glow for every new player drawn, disabled enabling of xray when dead spectating teammates, moves the toggle off of xray vision when changing teams to clientmodeshared
Toolchain
Linked Issues