Fix knife incorrect initial secondary attack#741
Merged
Conversation
Fix a problem where the knife swing could be incorrectly triggered once using the `+attack2` input. This is a supplementary fix to NeotokyoRebuild#708 since I forgot to address the knife stuff in the earlier PR NeotokyoRebuild#714 that closed it. We had some buggy scaffolding in place for a speculative future secondary attack for the knife, but in the spirit of YAGNI I've decided to delete it for now to simplify the code.
brysondev
approved these changes
Oct 16, 2024
AdamTadeusz
approved these changes
Oct 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a problem where the knife swing could be incorrectly triggered once, using the
+attack2input.This is a supplementary fix to #708 since I forgot to address the knife stuff in the earlier PR #714 that closed the issue.
We had some buggy scaffolding in place for supporting a speculative future secondary attack feature for the knife, but in the spirit of YAGNI I've decided to delete it for now to simplify the code.
To reproduce
See #708 (only the knife case is applicable here, grenades should be already fixed).
Toolchain
Linked Issues