Fix grenade bugs#714
Merged
Merged
Conversation
brysondev
previously approved these changes
Oct 13, 2024
brysondev
left a comment
brysondev
left a comment
Contributor
There was a problem hiding this comment.
Just one question but lgtm
Fix NeotokyoRebuild#708 Fix NeotokyoRebuild#713 Fix problems with throwable items like grenades. This PR disables priming throwables with the +attack2/"alt fire" button, as that seemed to be happening by mistake. This also removes the experimental underhanding/lobbing of grenades feature. This was never really properly implemented, and was just remnants from tests years ago. It's not parity, and if we wanted this kind of system in the future, it should probably go through a proper design doc process to be added. Finally, this fixes the inability to throw grenades/throwables whilst sprinting - parity behaviour is to allow throwing of nades regardless of sprint state.
brysondev
approved these changes
Oct 13, 2024
AdamTadeusz
approved these changes
Oct 13, 2024
Rainyan
added a commit
to Rainyan/rebuild
that referenced
this pull request
Oct 16, 2024
Fix a problem where the knife swing could be incorrectly triggered once using the `+attack2` input. This is a supplementary fix to NeotokyoRebuild#708 since I forgot to address the knife stuff in the earlier PR NeotokyoRebuild#714 that closed it. We had some buggy scaffolding in place for a speculative future secondary attack for the knife, but in the spirit of YAGNI I've decided to delete it for now to simplify the code.
Rainyan
added a commit
that referenced
this pull request
Oct 20, 2024
Fix a problem where the knife swing could be incorrectly triggered once using the `+attack2` input. This is a supplementary fix to #708 since I forgot to address the knife stuff in the earlier PR #714 that closed it. We had some buggy scaffolding in place for a speculative future secondary attack for the knife, but in the spirit of YAGNI I've decided to delete it for now to simplify the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix problems with throwable items like grenades.
This PR disables priming throwables with the
+attack2/"alt fire" button, as that seemed to be happening by mistake.This also removes the experimental underhanding/lobbing of grenades feature. This was never really properly implemented, and was just remnants from tests years ago. It's not parity, and if we wanted this kind of system in the future, it should probably go through a proper design doc process to be added.
Finally, this fixes the inability to throw grenades/throwables whilst sprinting - parity behaviour is to allow throwing of nades regardless of sprint state.
Toolchain
Linked Issues