Skip to content

Spatial reload sounds, stop reload sounds when dropping or switching weapon, fix for weapons reloading on the floor#610

Merged
AdamTadeusz merged 4 commits into
NeotokyoRebuild:masterfrom
AdamTadeusz:042_weaponReloadsSpatialAndStopWhenSwitchingWeapons
Sep 30, 2024
Merged

Spatial reload sounds, stop reload sounds when dropping or switching weapon, fix for weapons reloading on the floor#610
AdamTadeusz merged 4 commits into
NeotokyoRebuild:masterfrom
AdamTadeusz:042_weaponReloadsSpatialAndStopWhenSwitchingWeapons

Conversation

@AdamTadeusz

@AdamTadeusz AdamTadeusz commented Sep 18, 2024

Copy link
Copy Markdown
Contributor

Description

reload_npc is the same reload sound as reload except with the character that allows for spatial sounds.

Toolchain

  • Windows MSVC VS2022
  • Linux GCC Distro Native [Specify distro + GCC version]
  • Linux GCC 10 Sniper 3.0

Linked Issues

…tch. Also fixes weapons reloading when on the floor.
Rainyan
Rainyan previously approved these changes Sep 19, 2024

@Rainyan Rainyan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rainyan
Rainyan requested a review from a team September 19, 2024 09:01
Comment thread mp/src/game/server/neo/neo_player.cpp Outdated
Rainyan
Rainyan previously approved these changes Sep 19, 2024
@AdamTadeusz AdamTadeusz changed the title Spacial reload sounds, stop reload sounds when dropping or switching weapon, fix for weapons reloading on the floor Spatial reload sounds, stop reload sounds when dropping or switching weapon, fix for weapons reloading on the floor Sep 20, 2024
@AdamTadeusz
AdamTadeusz requested a review from Rainyan September 20, 2024 11:33
@AdamTadeusz AdamTadeusz added the New Changes for Reviewers New changes has been made. This label is mostly to notify reviewers. label Sep 20, 2024
@AdamTadeusz
AdamTadeusz merged commit 31044a9 into NeotokyoRebuild:master Sep 30, 2024
@AdamTadeusz
AdamTadeusz deleted the 042_weaponReloadsSpatialAndStopWhenSwitchingWeapons branch September 30, 2024 08:54
@Rainyan
Rainyan removed their request for review October 15, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Changes for Reviewers New changes has been made. This label is mostly to notify reviewers.

Projects

None yet

4 participants