End reload sound when switching with fast switch enabled

[AdamTadeusz]

Description

Plays WeaponSelected if weapon was succesfully selected using FastWeaponSwitch. Semantically makes sense to play WeaponSelected where DenyWeaponSelection is already played if FastWeaponSwitch returns false, however although the sound WeaponSelected is already played for the other weapon selection methods, it is never audible as in all other cases CloseWeaponSelection is played afterwards in the same channel, overwriting this sound.

If the same sound should be heard regardless of weapon selection method then either the sound added here should be replaced with CloseWeaponSelection which is audibly much louder to the player, is not heard ever when using the default weapon switch method in the original, and is a sound closely associated with the source engine (and perhaps should therefore be avoided). The alternative therefore would be to remove the CloseWeaponSelection sound from the other weapon selection methods, which would make the WeaponSelected sound that is also played in those instances audible.

Toolchain

• Windows MSVC VS2022
• Linux GCC Distro Native [Specify distro + GCC version]
• Linux GCC 10 Sniper 3.0

Linked Issues

• fixes Player reload sound persists when switching weapons #606

[AdamTadeusz]

Fixed by #610, although maybe should still consider the inconsistencies in sounds heard when switching weapons using the different methods