Repository navigation
Bumping Master - #329
Merged
Merged
Bumping Master#329
Conversation
Get NPE to read a list of packages from an apt_requirements.txt file in the plugin root directory and install them.
Remove python-pip from the list of required apt packages. Phonetisaurus used to require python2, but it appears to run fine under python3 now, and Ubuntu 20.04 no longer has a python-pip package.
* Force Update & Uninstall
* Swapping order of operations
* Uninstall
${NAOMI_BASE}/naomi-setup.sh was not passing arguments to
${NAOMI_BASE}/installers/naomi-setup.sh, so passing arguments
to the first script had no effect on the second, which was
expecting the arguments.
I also changed the argument from "-uninstall" or "uninstall" to
"--uninstall" which is a more typical way to pass arguments in
Linux. I also changed the "Continue?" prompt to accept lower
case y/n and used SUDO_COMMAND to give the user a chance to
cancel if they don't want to delete the ~/Naomi or ~/.config/naomi
directories.
Co-authored-by: Aaron Chantrill <aaron.chantrill@dottywood.org>
* New Scripting * codacy is no longer active, setup lgtm * fixing apt variable * Making sure testing config file is set properly * Adjusting Quit from root menu
Doing a sudo git is causing problems because all the files in and including the ~/Naomi directory end up owned by root:root. It is then impossible to create the Naomi.sh file using the normal user account which is causing the installation to fail.
Cleaning Up More Sudo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since stable 3.0 release there has been many big breaking changes that have been made in dev that need to be included in stable to make sure it works properly with dependencies and the new install scripting.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: