Skip to content

Removing DeepSpeech from core - #320

Merged
aaronchantrill merged 1 commit into
NaomiProject:naomi-devfrom
AustinCasteel:removing-deepspeech-from-core
Feb 2, 2021
Merged

aaronchantrill merged 1 commit into
NaomiProject:naomi-devfrom
AustinCasteel:removing-deepspeech-from-core

Conversation

@AustinCasteel

Copy link
Copy Markdown
Member

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aaronchantrill

Copy link
Copy Markdown
Contributor

This looks correct to me. Looks like the Deepspeech plugin has moved to https://github.com/AustinCasteel/deepspeech-stt.git

I am running a test.

@aaronchantrill

Copy link
Copy Markdown
Contributor

Well, I know I had intended to allow plugins to include an "apt_requirements.txt" file, but apparently I never did. I have implemented parsing an apt file and am about to upload it. The deepspeech package you created works fine with it.

@aaronchantrill

Copy link
Copy Markdown
Contributor

If you are done, I'm happy to merge this.

@AustinCasteel

Copy link
Copy Markdown
Member Author

@aaronchantrill Good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants