fix: libraft-headers-only declares unused C compiler - #3116
fix: libraft-headers-only declares unused C compiler#3116andrewwhitecdw wants to merge 2 commits into
Conversation
Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Changeslibraft packaging
Estimated code review effort: 1 (Trivial) | ~2 minutes Mergeability Score: ⚪ Minimal · up to This localized recipe cleanup removes an unused C compiler dependency and introduces no actionable merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Thanks for putting this in @andrewwhitecdw -- before we kick off a full CI build-and-test, can you verify locally that you can build the new recipe without the compilers metapackage available?
Copying and pasting the relevant terminal output is sufficient proof. Thanks!
|
The common issue between #3114 #3115 and this PR is whether cmake needs the compiler to be present in order to carry out its install steps. The header package certainly does not need the compiler, but cmake might check for it anyway for the sake of platform checks. In my opinion, you should close #3114 and #3115 and incorporate those changes here. Either it'll work for all of them or none of them, and you'll save test time. |
This PR addresses the following issue in
conda/recipes/libraft/recipe.yaml: libraft-headers-only declares unused C compiler.Changes
conda/recipes/libraft/recipe.yaml: libraft-headers-only declares unused C compiler.Details
Tests