Skip to content

fix: libraft-static output declares unused C compiler - #3115

Closed
andrewwhitecdw wants to merge 2 commits into
NVIDIA:mainfrom
andrewwhitecdw:codequality/recipe-libraft-static-output-declares-unused
Closed

fix: libraft-static output declares unused C compiler#3115
andrewwhitecdw wants to merge 2 commits into
NVIDIA:mainfrom
andrewwhitecdw:codequality/recipe-libraft-static-output-declares-unused

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

This PR addresses the following issue in conda/recipes/libraft/recipe.yaml: libraft-static output declares unused C compiler.

Changes

  • conda/recipes/libraft/recipe.yaml: libraft-static output declares unused C compiler.

Details

--- a/conda/recipes/libraft/recipe.yaml
+++ b/conda/recipes/libraft/recipe.yaml
@@ -1,16 +1,15 @@
-  - package:
-      name: libraft-static
-      version: ${{ version }}
-    build:
-      string: cuda${{ cuda_major }}_${{ datetime_string }}_${{ head_rev }}
-      dynamic_linking:
-        overlinking_behavior: "error"
-      script:
-        content: |
-          cmake --install cpp/build --component compiled-static
-    requirements:
-      build:
-        - cmake ${{ cmake_version }}
-        - ${{ compiler("c") }}
-      host:
-        - ${{ pin_subpackage("libraft-headers", exact=True) }}
+  - package:
+      name: libraft-static
+      version: ${{ version }}
+    build:
+      string: cuda${{ cuda_major }}_${{ datetime_string }}_${{ head_rev }}
+      dynamic_linking:
+        overlinking_behavior: "error"
+      script:
+        content: |
+          cmake --install cpp/build --component compiled-static
+    requirements:
+      build:
+        - cmake ${{ cmake_version }}
+      host:
+        - ${{ pin_subpackage("libraft-headers", exact=True) }}

Tests

Let me know if you want tests added for this fix or not.

Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
@andrewwhitecdw
andrewwhitecdw requested a review from a team as a code owner August 13, 2026 01:34
@copy-pr-bot

copy-pr-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 13a51895-1114-4f81-9549-a7f8eb27ebf3

📥 Commits

Reviewing files that changed from the base of the PR and between e2437c4 and 1032541.

📒 Files selected for processing (1)
  • conda/recipes/libraft/recipe.yaml
💤 Files with no reviewable changes (1)
  • conda/recipes/libraft/recipe.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Streamlined the static library package build configuration by removing an unnecessary build requirement.

Walkthrough

The libraft-static conda output no longer declares the C compiler in its build requirements. CMake remains declared.

Changes

libraft-static build requirements

Layer / File(s) Summary
Remove redundant C compiler requirement
conda/recipes/libraft/recipe.yaml
The libraft-static build requirements remove ${{ compiler("c") }} and retain CMake.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to 10325

This localized recipe cleanup removes an unused build dependency and introduces no actionable merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: msarahan

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the removal of the unused C compiler declaration from the libraft-static output.
Description check ✅ Passed The description directly explains the removal of the unused C compiler declaration and shows the exact recipe change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@msarahan

Copy link
Copy Markdown
Member

same as #3114

@msarahan msarahan closed this Aug 18, 2026
@msarahan

Copy link
Copy Markdown
Member

sorry, this may have been premature. Need confirmation, as in #3116

andrewwhitecdw added a commit to andrewwhitecdw/raft that referenced this pull request Aug 19, 2026
The libraft-headers-only, libraft, and libraft-static outputs list
${{ compiler("c") }} in their build requirements, but none of them
compile C source during those output builds. The top-level recipe already
requests the C compiler, so the per-output declarations are redundant.

This combines the changes from NVIDIA#3114 and NVIDIA#3115 into this PR per maintainer
feedback.

Signed-off-by: Andrew White <andrewwhitecdw@users.noreply.github.com>
@andrewwhitecdw

Copy link
Copy Markdown
Author

Closing per maintainer feedback in #3116 — these changes are being incorporated into #3116 so they can be validated together. See #3116 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants