fix: libraft-static output declares unused C compiler - #3115
fix: libraft-static output declares unused C compiler#3115andrewwhitecdw wants to merge 2 commits into
Conversation
Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Changeslibraft-static build requirements
Estimated code review effort: 1 (Trivial) | ~2 minutes Mergeability Score: ⚪ Minimal · up to This localized recipe cleanup removes an unused build dependency and introduces no actionable merge-blocking risk; it is merge-ready after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
same as #3114 |
|
sorry, this may have been premature. Need confirmation, as in #3116 |
The libraft-headers-only, libraft, and libraft-static outputs list
${{ compiler("c") }} in their build requirements, but none of them
compile C source during those output builds. The top-level recipe already
requests the C compiler, so the per-output declarations are redundant.
This combines the changes from NVIDIA#3114 and NVIDIA#3115 into this PR per maintainer
feedback.
Signed-off-by: Andrew White <andrewwhitecdw@users.noreply.github.com>
|
Closing per maintainer feedback in #3116 — these changes are being incorporated into #3116 so they can be validated together. See #3116 (comment). |
This PR addresses the following issue in
conda/recipes/libraft/recipe.yaml: libraft-static output declares unused C compiler.Changes
conda/recipes/libraft/recipe.yaml: libraft-static output declares unused C compiler.Details
Tests