Repository navigation
Conversation
Originally NVIDIA#7487. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#6259. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#6293. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
…groups Originally NVIDIA#8042. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8043. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8045. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8731. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#6257. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#6303. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8026. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8723. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8017. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8039. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8049. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8037. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8048. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8726. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8727. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8740. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8742. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8817. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8022. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8023. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8025. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
… converter Originally NVIDIA#8033. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8044. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8760. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8758. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8761. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8759. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8735. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8749. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8821. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8818. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8819. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8765. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8766. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8767. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8768. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8775. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8755. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8763. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
…Collection Originally NVIDIA#7991. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8769. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8770. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Originally NVIDIA#8772. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This was referenced Nov 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finishes the core side of the
parallel_statedeprecation (#6307). The last two unwarned reads of the global grid in Megatron Core move behind their fallback warnings, andresolve_gtp_remat_groupwarns before it reads the grid. The process-group checker now tells warned reads from unwarned ones, and a new test fails once the package version reaches an announced removal version. Pytest turns aParallelStateDeprecationWarningraised from this repository's own code outside the tests into an error. The docs describe the CI check, how to build aProcessGroupCollectionwithout the globals, and common ways a component ends up on the wrong groups. It is for callers who build layers without a collection, and for maintainers of Megatron Core, MoE, the transformer layers and CI. It consolidates four draft PRs unchanged. Each member is one commit, so review commit by commit. A final commit regeneratestools/process_group_usage_allowlist.json. It builds on #6257 and on the units for FP8 amax, CUDA graphs and 1F1B (#8038), attention and layers (#8729), MoE plumbing (#8724), DDP and Megatron-FSDP (#8725), transformer and MoE warnings (#8748, #8732, #8057, #8060, #8073), DDP/FSDP warnings (#8735, #8749), the registry and tools (#8059), checkpoint-helper warnings (#8756), optimizer warnings (#8752, #8734), core helper warnings (#8755) and the accessor deprecation (#8767). It lands after all of them.Review
The unit's own commits: Connor-XY/Megatron-LM@4df70b1...61b02bb
The full PR diff also shows the earlier units until they merge.
Members
ProcessGroupCollectionfrom aHyperCommGridand on 11 failure patterns, and updates the Core QuickStart to pass groups explicitly and train withget_megatron_optimizer, with no runtime change.SequentialMLPpasses its collection to each expert MLP.:warnedallowlist suffix) and counts the GTP and setup helpers as guarded, the guard outside core follows aliases,getattr,importliband star imports, and the PR adds a blocking removal-version test and a pytest error filter; the filter is a separatepyproject.tomlchange that can be dropped on its own.MoEMetricsTracker._sync_metricsandmtp_on_this_rankread inside their warned branches, leaving 0 unwarned core reads, and Attention, the MTP block and MoE's default collection add the GTP fields to their fallback collections, so an owner built without a collection gives 1 warning instead of 3 to 5.Behavior changes for callers
pg_collection, or with a collection that lacksgtp_rematorexpt_gtp_remat, now emitsProcessGroupFallbackWarningeven with GTP off, and raises under--strict-process-group-fallbacks. Set both fields, toNonewhen an axis is off, to avoid it.MoELayerbuilt withpg_collection=None, Transformer Engine grouped GEMM and expert GTP above 1 now shards its experts over the global expert GTP group. Before, it did not. With expert GTP off nothing changes.ParallelStateDeprecationWarningwhose caller is repository code outside the tests becomes an error. Other packages stay ignored.:warnedsuffix.--updateconverts an old allowlist.megatron/core/package_info.pyreaches a version that a warning announces as the removal version.Teams
ci, core-adlr, core-nemo, mixture-of-experts-adlr, mixture-of-experts-devtech, transformer
Testing
Each member was GPU-tested against its base before consolidation. GTP-on paths were checked separately with a Transformer Engine 2.19 development build: 33 test files, no regressions against main. The consolidated chain (every unit in landing order, on current main) was run against main on 4 GPUs: 258 test files, and no test fails on the chain that passes on main. Tests in 28 files fail on both, mostly tests written for 8 GPUs, and one file times out on both.
🤖 Generated with Claude Code