Repository navigation
Conversation
Contributor
Author
|
Part of #6307 — tracking issue for the |
Connor-XY
force-pushed
the
yx/pstate-p0-mark-deprecation
branch
from
August 19, 2026 19:31
5fee2db to
1715e47
Compare
Connor-XY
marked this pull request as ready for review
August 19, 2026 19:31
Connor-XY
force-pushed
the
yx/pstate-p0-mark-deprecation
branch
from
September 8, 2026 20:29
1715e47 to
e84f312
Compare
Connor-XY
force-pushed
the
yx/pstate-p0-mark-deprecation
branch
from
September 18, 2026 18:24
e84f312 to
bbb2457
Compare
Connor-XY
force-pushed
the
yx/pstate-p0-mark-deprecation
branch
from
September 30, 2026 22:17
bbb2457 to
a40dd76
Compare
Contributor
Author
|
/ok to test a40dd76 |
Contributor
Author
|
/ok to test 7a4a53b |
Document caller-provided process groups as the migration path for Megatron Core. Mark 56 legacy accessors with replacement guidance and clarify compatibility shim boundaries, expert and GTP group selection, global rank conversion, and optional-group semantics. Keep executable code unchanged. Signed-off-by: Yan Xu <yxu1@nvidia.com>
The new page was only linked from contribute.md, so Sphinx warned that it is not included in any toctree and the warnings-as-errors docs build failed. Signed-off-by: Yan Xu <yxu1@nvidia.com>
Connor-XY
force-pushed
the
yx/pstate-p0-mark-deprecation
branch
from
October 1, 2026 21:07
7a4a53b to
399a917
Compare
Contributor
Author
|
/ok to test 399a917 |
yaoyu-33
approved these changes
Oct 5, 2026
Adapted to main outside the conflicts: - megatron/core/parallel_state.py: NVIDIA#7047 added the ProcessGroupCollection fields dynamic_cp and dynamic_tp_cp. The deprecation note on get_dynamic_data_context_parallel_groups now points to pg_collection.dynamic_cp[group_size] instead of saying no field exists. The three dynamic group accessors main added since this PR was written now carry the standard deprecation note, pointing to the dynamic_cp and dynamic_tp_cp fields. Only docstrings change. - docs/developer/parallel-state-deprecation.md: The "no corresponding fields" sentence now covers only Gloo groups. The guide maps the dynamic (formerly hybrid) groups to dynamic_cp and dynamic_tp_cp, keyed by runtime CP size, and the group table gains rows for both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Yan Xu <yxu1@nvidia.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global
parallel_stateaccessors cannot select an independent model's parallel grid. Document caller-providedProcessGroupCollection/ProcessGrouparguments as the migration path, mark 59 accessors with replacement guidance, and clarify where the compatibility shim remains appropriate.Include current dense/expert, GTP-remat, and dynamic CP group mappings, global versus group-local rank conversion, optional-group and initialization semantics, and the limits of physical pipeline-stage helpers. This is documentation-only: executable ASTs for both Python files are unchanged from main (
77391e71cc). Upstream #7045 renamed the hybrid DP×CP accessor toget_dynamic_data_context_parallel_groups(keepingget_hybrid_data_context_parallel_groupsas a deprecated alias); the deprecation note now sits on the new accessor. Upstream #7047 added thedynamic_cpanddynamic_tp_cpfields toProcessGroupCollection. The note onget_dynamic_data_context_parallel_groupspoints topg_collection.dynamic_cp[group_size], and the three dynamic group accessors main added since this PR was written carry the standard deprecation note. The guide maps the dynamic (formerly hybrid) groups todynamic_cpanddynamic_tp_cp, keyed by runtime CP size, and only Gloo groups have no corresponding collection fields.Validation: Black 26.3.0, isort, Ruff, pylint, syntax, and
git diff --checkpass. The local mypy run reports the same 13 dependency/type diagnostics as main. The lint and mypy results are from the branch before the sync; after the sync,git diff --checkpasses and the merge changes only docstrings and the guide. No GPU execution is needed for this documentation-only change. The PR touches no test files, and the integration run of all #6307 PRs on main shows no regressions against main.The branch was synced with main 77391e7 on 2026-11-01 by a merge commit, so existing commits and review links stay valid. The merge had no conflicts; its message lists the docstring and guide updates for main's changes.
Related to #6307.