Repository navigation
feat(models): disable auxiliary MTP training without changing checkpoint topology - #7384
Closed
arnavkomaragiri wants to merge 1 commit into
Closed
arnavkomaragiri wants to merge 1 commit into
arnavkomaragiri wants to merge 1 commit into
Conversation
…int topology Signed-off-by: Arnav Komaragiri <akomaragiri@nvidia.com>
This was referenced Sep 16, 2026
Open
Draft
Author
|
Superseded by the NRL-owned Hybrid MTP control in NVIDIA-NeMo/RL#4147, using the existing compute_mtp_loss forward argument and pre-wrap parameter freezing. The replacement passed FP32/BF16 logits/base-gradient parity, checkpoint-key/bypass checks and the async 1x16 gate. Closing without merging; #7387 no longer depends on this proposal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded
Retired in favor of NRL-owned Hybrid MTP control in NVIDIA-NeMo/RL#4147: freeze retained MTP weights before DDP/optimizer setup and pass the existing upstream
compute_mtp_loss=Falseargument through policy forwards. Unsupported MTP-bearing models fail explicitly; no new MCore config field or checkpoint topology change is needed.The replacement passed FP32/BF16 Hybrid logits/base-gradient parity, checkpoint-key and bypass checks, plus the async 1x16 TQ/R3/CP2 gate. No active PR in this stack depends on this proposal. #7387 is the sole remaining MCore change.
Historical Proposal
Add opt-in
TransformerConfig.disable_mtp_lossfor fine-tuning an MTP checkpoint without the auxiliary MTP training forward or vocabulary loss.mtp_num_layers.compute_mtp_losscontrol.freeze_base_model_for_mtp.Setting an MTP loss coefficient to zero alone still computes the auxiliary vocabulary projection. This option avoids that compute and peak allocation without removing model structure.
Tests
Added native model tests for strict checkpoint loading with unchanged keys, frozen MTP/trainable base parameters, skipped MTP forward/loss, and a functioning base backward pass for GPT and Hybrid. These new model tests require CUDA/Transformer Engine and have not been executed on the login host; CI execution is required before readiness.
The extracted production behavior was exercised in the successful integrated async 1x16 Harbor training gate, with finite nonzero gradient norm. Tested MCore base:
54c62dfb6852e9218bf38590be9b90930bf7d589. New upstream changes have not yet been reconciled and revalidated.Stack
No longer a prerequisite. The historical patch is retained here for reference; its implementation is not carried by the active shared-prefix PR.
Review Status
Superseded; closed without merging.