Repository navigation
feat(policy): execute bounded exact-call and shared-prefix training layouts - #4147
Draft
arnavkomaragiri wants to merge 5 commits into
Draft
arnavkomaragiri wants to merge 5 commits into
arnavkomaragiri wants to merge 5 commits into
Conversation
Signed-off-by: Arnav Komaragiri <akomaragiri@nvidia.com>
Signed-off-by: Arnav Komaragiri <akomaragiri@nvidia.com>
Signed-off-by: Arnav Komaragiri <akomaragiri@nvidia.com>
…ayouts Signed-off-by: Arnav Komaragiri <akomaragiri@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This was referenced Sep 16, 2026
Closed
Draft
Signed-off-by: Arnav Komaragiri <akomaragiri@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Dependencies
Depends on: NVIDIA-NeMo/RL#4146, NVIDIA/Megatron-LM#7387.
Required by: NVIDIA-NeMo/RL#4148.
Summary
Connect packed exact-call/tree layouts to policy execution for legacy and TQ training.
keep_train_bufferscontract; reject destructive offload and checkpoint saves while a step is open.compute_mtp_loss=Falsethrough every policy forward path. No checkpoint topology change or MCore config extension.Dependencies
Stacked after #4146, using representation/transport primitives from #4144 and #4145.
The sole required MCore change is NVIDIA/Megatron-LM#7387, for shared-prefix model execution. Gradient lifetime and Hybrid MTP control use existing upstream APIs and are implemented here, with their tests.
This draft is not merge-ready with the existing MCore pin. The feature imports the new tree API. Bridge has no new implementation in this series; its MCore gitlink and RL dependency pins must be reconciled after the dependencies are accepted. Local fork pins are deliberately not hidden in this feature diff.
Validation And Limitations
Matching policy, model-data, projection, split-step, and routing regressions are included. September 16 validation with only shared-prefix changes in MCore:
The 1x16 run consumes one prompt group; inter-group gradient lifetime is additionally covered by the focused two-chunk GPU test, not a claim of a multi-step production run.
The known BF16 Mamba gradient discrepancy remains documented in the MCore draft; an upstream fused/unfused control also differs. This patch neither fixes that separate precision issue nor weakens its tests.
Scoped formatting, Python parsing, added-line privacy, and whitespace checks pass. The focused GPU tests above ran in the normal CUDA/TE container; full native CI, complete typechecking and latest-main reconciliation remain pending. Controller heartbeat and terminal-dispatch/shutdown warnings did not affect the consumed group and remain separate cleanup items.
Draft for author review only; no deployment recipes, datasets, or live jobs are changed.