Repository navigation
[NCCL EP] Add MXFP8 dispatch support - #6524
Merged
Merged
Conversation
Signed-off-by: YangFei1990 <feiw@nvidia.com>
Signed-off-by: YangFei1990 <feiw@nvidia.com>
Signed-off-by: YangFei1990 <feiw@nvidia.com>
Signed-off-by: YangFei1990 <feiw@nvidia.com>
Signed-off-by: YangFei1990 <feiw@nvidia.com>
Signed-off-by: YangFei1990 <feiw@nvidia.com>
…l_ep_fp8_dispatch
Signed-off-by: YangFei1990 <feiw@nvidia.com>
Signed-off-by: YangFei1990 <feiw@nvidia.com>
svcnvidia-nemo-ci
marked this pull request as draft
August 13, 2026 22:08
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
yaox12
approved these changes
Aug 14, 2026
Signed-off-by: YangFei1990 <feiw@nvidia.com>
Phlip79
approved these changes
Aug 20, 2026
jaredcasper
approved these changes
Aug 20, 2026
YangFei1990
enabled auto-merge
August 20, 2026 17:02
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/32440023722 |
dimapihtar
pushed a commit
to dimapihtar/Megatron-LM
that referenced
this pull request
Aug 21, 2026
Signed-off-by: YangFei1990 <feiw@nvidia.com> Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>
devnkong
pushed a commit
to devnkong/Megatron-LM
that referenced
this pull request
Aug 22, 2026
Signed-off-by: YangFei1990 <feiw@nvidia.com> Signed-off-by: Kezhi Kong <kezhik@kezhik-mlt.client.nvidia.com>
This was referenced Aug 27, 2026
ksivaman
pushed a commit
to ksivaman/Megatron-LM
that referenced
this pull request
Sep 1, 2026
Signed-off-by: YangFei1990 <feiw@nvidia.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds options to specify dtype for dispatch forward and combine backward (which is also a dispatch op). Currently it only supports bf16 and MXFP8
Note: the contract with TE is temporary, supported by this PR NVIDIA/TransformerEngine#3355. It allows to let TE return plain torch tensor, so mcore side does not require any special handling. In the future we will return grouped tensor, but make it compatible with mcore code path.
Contribution process
Pre-checks
Code review
Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.