Update to XML file structure used for patching parameter files via "BatchPatchParams.py"#916
Merged
Merged
Conversation
…ml format of the batch patch.
glemieux
reviewed
Oct 27, 2022
| new_cdl = xmlroot.find('new_file').text | ||
|
|
||
| pftparams = xmlroot.find('pft_list').text.replace(" ","") | ||
| pftparams = xmlroot.find('pft_trim_list').text.replace(" ","") |
Contributor
There was a problem hiding this comment.
Out of curiosity, what made you decide to change this variable name?
Update BatchPatchParams stack to modify the history attribute
glemieux
approved these changes
Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This set of changes updates the format of the the parameter file patching system. The key change is that the xml patch files now have a new specifier that flags which PFTs should be changed. In the old system, it was assumed that the user had to write in all of the parameters for all PFTs that should be used, instead of just the ones that are of interest.
To be clear, this refers to the use of the routine tools/BatchPatchParams.py and the XML files that work with it.
The file parameter_files/patch_default_bciopt224.xml is updated and can still be used a a template for other users.
Old format:
New Format:
Collaborators:
@jenniferholm
Expectation of Answer Changes:
none
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: