Update BatchPatchParams stack to modify the history attribute#11
Merged
rgknox merged 2 commits intoOct 31, 2022
Merged
Conversation
rgknox
approved these changes
Oct 31, 2022
rgknox
pushed a commit
that referenced
this pull request
Apr 23, 2024
added parameters and merged up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I noticed testing this that the
:historyattribute was comprised of all the history updates from the modify_fates_paramfile.py script call. I updated that call to prevent the history recording and also added a similar option to the FatesPFTIndexSwapper.py script. Finally I used a quick and dirty method to get access to thespicy.iohistorymethod to modify the attribute with a custom output similar to the FatesPFTIndexSwapper.py. For some reason it exposes the newline characters even as it obeys them, which I don't get.I also removed one line of what appeared to be dead code.
Collaborators:
Expectation of Answer Changes:
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: