Skip to content

Update BatchPatchParams stack to modify the history attribute#11

Merged
rgknox merged 2 commits into
rgknox:update_batchpatchfrom
glemieux:update_batchpatch-histchange
Oct 31, 2022
Merged

Update BatchPatchParams stack to modify the history attribute#11
rgknox merged 2 commits into
rgknox:update_batchpatchfrom
glemieux:update_batchpatch-histchange

Conversation

@glemieux

Copy link
Copy Markdown
Collaborator

Description:

I noticed testing this that the :history attribute was comprised of all the history updates from the modify_fates_paramfile.py script call. I updated that call to prevent the history recording and also added a similar option to the FatesPFTIndexSwapper.py script. Finally I used a quick and dirty method to get access to the spicy.io history method to modify the attribute with a custom output similar to the FatesPFTIndexSwapper.py. For some reason it exposes the newline characters even as it obeys them, which I don't get.

I also removed one line of what appeared to be dead code.

Collaborators:

Expectation of Answer Changes:

Checklist:

  • My change requires a change to the documentation.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@rgknox rgknox merged commit 72866b4 into rgknox:update_batchpatch Oct 31, 2022
rgknox pushed a commit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants