Repository navigation
test(engine): cover camelCase @unique on append and merge loads - #875
Merged
azimafroozeh merged 1 commit intoOct 4, 2026
Merged
Conversation
azimafroozeh
approved these changes
Oct 4, 2026
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
#765 reported that writes into a type with a camelCase
@uniqueproperty failed withNo field named versiontag, forload --mode append,load --mode mergeandmutate … insert. #768 fixed the committed-uniqueness probe (col→identinCommittedState::unique_holders), but its regression case,issue_765_camelcase_unique_property_insert.gqt, only coversinsert. The two load modes reach the same probe throughCommittedState::load, and no test covers them. A GQT case can't: GQT seeds only with Overwrite, which skips the committed probe.This adds
load_issue_765_camelcase_unique_column_loads_and_rejects_duplicatestocrates/omnigraph/tests/validators.rs. For both Append and Merge, it loadsMessage { slug @key, messageId @unique }into an empty graph. It then checks that a second load with the samemessageIdis refused with@unique violation on Message.messageIdand leaves one row.Backing issue / RFC
No field named versiontag) #765 (accepted, closed by fix(engine): use literal identifiers for property names #768; this adds the missing load-path regression test)Checklist
Local verification
cargo test --locked -p omnigraph-engine --test validators issue_765: 1 passedcargo test --locked -p omnigraph-engine --test validators: 35 passedcargo fmt --all --check: cleancargo clippy -p omnigraph-engine --all-targets --locked -- -D warnings -W clippy::dbg_macro: cleanidentback tocolinCommittedState::unique_holdersmakes the test fail with the originalNo field named messageid … lance-datafusion-11.0.0/src/planner.rs:1025:20. With the mode order swapped, the Merge load fails the same way, so each mode catches the bug on its own.Notes for reviewers
CommittedState::loadview, and the loop keeps a single schema and body.@keyneeds no test here: keyed loads upsert on the__idsystem column (MergeInsertBuilder::try_new(ds, vec![system_columns.id])), so the key column's name never reaches a filter.