Repository navigation
fix(engine): use literal identifiers for property names - #768
Merged
azimafroozeh merged 1 commit intoSep 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #765. Writes with a camelCase
@uniqueproperty fail because the uniqueness probe lowercases the property name.ident()instead ofcol()to preserve the exact property name.interval,exists, andtrimparse as identifiers. Remove the pending-scan normalization override, which quoting makes unnecessary.Backing issue / RFC
issue_765_camelcase_unique_property_insert.gqt).Checklist
docs/dev/invariants.md: no Hard Invariant weakened or deny-list item hit (constraint rejection and publication order are preserved).Local verification
cargo test -p omnigraph-gqt --locked: 144 cases and 181 harness tests passed.cargo test -p omnigraph-engine --locked --features failpoints --test writes --test validators --test literal_filters --test lance_surface_guards --lib: 471 unit tests passed, 1 ignored; all four integration suites passed.cargo clippy -p omnigraph-engine --all-targets --locked --features failpoints -- -D warnings -W clippy::dbg_macro: passed.cargo fmt --all --check: passed.bash scripts/check-agents-md.sh: passed.python3 scripts/check-docs.py: passed../target/debug/omnigraph-vocabulary-guard check --surface openapi --base ed145db4c61d669d8200b14624583dd96ff359ff --inventory tools/omnigraph-vocabulary-guard/graph-vocabulary-inventory.tsv --openapi openapi.json: passed; 19 current and 19 base occurrences../target/debug/omnigraph-vocabulary-guard check --surface rust-string --base ed145db4c61d669d8200b14624583dd96ff359ff --inventory tools/omnigraph-vocabulary-guard/graph-vocabulary-inventory.tsv --openapi openapi.json: failed on unclassified occurrences and stale inventory entries in the merge base.Notes for reviewers
Backticks work as identifiers in both Lance and DataFusion. Double quotes would be incorrect here because Lance treats them as string literals. Verification covered the affected engine suites and complete GQT package; the full workspace was not run.