Repository navigation
docs(fold): gates 4–6 on gfx1151 for v0.35.0 — production's GPU code, and rocm7 admits the fold - #434
Merged
Conversation
The v0.35.0 fold (#427) moves no native input: llama.cpp stays b11081. As ADR 0032 says, its builds share the rocm7 profile, and the version pattern widens from 0.34.[34] to admit 0.35.0 as well. 0.35.1 stays refused, because its rc0 moves llama.cpp to b11232. 805 entered main with #371, after the promoted build, and the ROCm build applies it. So the patch set lists it, as it came to list 908. On gfx1151 it changes no GPU code. The fold image's libggml-hip.so has a byte-identical .hip_fatbin (60,336,816 bytes) and 64 more bytes of host .text, the GGML_CUDA_FATTN_FORCE_TILE switch. TestRocm7ProfileAdmitsTheV0350Fold pins the widening: - It admits production's stamp, the fold's interim stamp and the fold's tag stamp. - It refuses 0.35.1, a previous payload, a dirty tree and a point tag. - The resolver maps the tag stamp to this profile. - The patch set lists 805. The old pattern fails the admit test. test_verdicts.py passes 200 tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fold image, maxusai-ollama:0.34.4-dynres-41-gfedbe05-rocm7-gfx1151, was built from fedbe05. The run used production's environment on a bench container: f16, flash attention on, two-pass and two slots. It ran preflight with --quality. The interim stamp resolves to rocm7-0-34-4-dynres. The result is PASS=27 SKIP=5, VERDICT PASS. Against the promoted image's last run (preflight-rocm7-0344-aspect-gb43ee8e.json), 30 of 32 rows are identical, every measured value included. The two other rows are version and image_tag, which name the image. The record's patchset line is the profile's, which did not list 805 at run time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fold ran on gfx1151 in production's environment (f16 KV cache, flash attention on, the two-pass flow, two slots) and was compared with production's own build, 0.34.4-dynres-0-gb43ee8e. - Gate 4: a full build of fedbe05. One native library of five differs, libggml-hip.so. Its .hip_fatbin, all of its gfx1151 GPU code, is byte-identical to production's. 805 adds 64 bytes of host code. - Gate 5: PASS=27 SKIP=5. 30 of 32 rows equal production's run (#415), measured values included. - System One answers on qwen3.6 and refuses qwen3.8. A typical_p request gets a 200, and the value reaches llama-server's sampler. - Gate 6, think off: 0 of 4,902 scored cells differ. All 140 answers and all 200 OCRBench answers are byte-identical. - Gate 6, think on: no model loses a finish. qwen3.6 and gemma4:26b are byte-identical, their loops included. gemma4:31b differs in the suite because of the two-pass flow's slot race. Cold, its pass-1 thinking is byte-identical on both images, and production's own image puts pass 2 on either slot. The status table gets gfx1151's entries in rows 4-6, and the profiles table the widened rocm7 row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Review of #434 at Checked:
CUDA production cannot hit this race. The race needs two slots, and all 7 of its llama-server launches since the 0.34.4 deploy ran
|
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds gfx1151's record of gates 4–6 to #427's task doc, and widens the rocm7 preflight profile so that it admits the fold. It targets #427's branch, not
main. Everything in it was measured on gfx1151 only. In the CUDA host's sections it changes only what concerns gfx1151: gfx1151's entries in the status table's rows 4–6, and the rocm7 row of "Preflight profiles". Rows 4 and 5 now also say which host their existing text is about.What
The new section is "Gates 4–6 on gfx1151 (2026-09-30)" in
docs/maxusai/tasks/upstream-sync-0.35.0.md. The fold ran in production's environment (f16 KV cache, flash attention on, the two-pass flow, two slots), and was compared with production's own build,0.34.4-dynres-0-gb43ee8e.fedbe0507,maxusai-ollama:0.34.4-dynres-41-gfedbe05-rocm7-gfx1151. One native library of five differs,libggml-hip.so, and its.hip_fatbin(all of its gfx1151 GPU code) is byte-identical to production's. 805 adds 64 bytes of host code, a switch that nobody setstypical_prequest gets a 200 and a deprecation warning, and the value reaches llama-server's sampler. The promoted image refuses the same request with a 400Files:
docs/maxusai/tasks/upstream-sync-0.35.0.md: the section and the table entries above. Every output in the section is pasted verbatim from the tool that made it.docs/maxusai/vision-suite/preflight/expectations.toml:rocm7-0-34-4-dynres'sversion_patternadmits0.35.0as well as0.34.[34], as ADR 0032 says for a fold that moves no native input. 0.35.1 stays refused, because its rc0 moves llama.cpp. Thepatchsetlists 805, because every build since docs: rocBLAS on gfx1151 — both runtime routes closed, and why #371 carries it.docs/maxusai/vision-suite/preflight/test_verdicts.py:TestRocm7ProfileAdmitsTheV0350Foldpins both changes. The old pattern fails it.docs/maxusai/vision-suite/preflight/runs/preflight-rocm7-0350-fold-gfedbe05.json: the gate 5 run record. It is force-added past theruns/ignore, as the other cited records are.Finding: in the suite, two-pass think-on does not repeat byte for byte
gemma4:31b runs greedy, and both arms send the same prompts, sampler and llama-server flags. Yet its thinking differs in 17 of 28 cells.
A correction
My gate 6a comment on #427 quoted a
cmp_raw.pythat compared two keys the answer files do not have, so it would report "byte-identical" for any two runs. The corrected tool compares file bytes. It gives the same result, 140 of 140, and it finds the differences on gemma4:31b's think-on. The correction is on #427 (comment).Verification
test_verdicts.py: 200 tests OK.tomllibloadsexpectations.toml.check_source_paths.py --changed-since origin/task/upstream-sync-0.35.0: every referenced file resolves.check_no_names.pywith a local deny-list file, over the tree and this branch's commits: no match.amd-server/rocm-gfx1151🤖 Generated with Claude Code