Repository navigation
preflight: gfx1151's aspect ladders; every check that can run on rocm7 now does - #415
Merged
Merged
Conversation
…eck that can run here now does The rocm7 profile recorded no aspect ladder, so check_aspect_ladder read SKIP on all three arches. This records them, measured 2026-09-29 on the promoted image 0.34.4-dynres-0-gb43ee8e in production's environment by the probe calls the check makes (image_prefix, then visual_tokens at 4:3, 4:1 and 1:1); each line is the generator's output (aspect_measure.py in the run directory), pasted whole. - nemotron_h_omni 770 / 902 / 578: the native grid at stride 32, plus the two markers. - gemma4 1066 / 1058 / 1091: the 1120-token budget fill at stride 48; equal to mlx-metal's gemma4 row. - qwen35 1038 / 1026 / 1026: every ratio raised to the 1024-token minimum at stride 32. A preflight with them, on the same image and environment, passed: VERDICT PASS, PASS=27 SKIP=5 (was 24/8), the aspect ladder 3/3 on every arch. The five skips left are the four Metal and MLX checks and qwen35's pinned budget, none of which applies on gfx1151. The run record is committed; the README's matrix, whose columns it does not change, now names it as gfx1151's newest run, and the gate records the step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 30, 2026
Merged
docs(fold): gates 4–6 on gfx1151 for v0.35.0 — production's GPU code, and rocm7 admits the fold
#434
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rocm7-0-34-4-dynresprofile recorded no aspect ladder, socheck_aspect_ladderread SKIP on all three arches. That was the last check skipped for want of an expectation on gfx1151. This records the three ladders, at the maintainer's word.Measured
Measured 2026-09-29 on the promoted image
0.34.4-dynres-0-gb43ee8e, in a bench container with production's environment. The measurement makes the check's own probe calls:image_prefix(B8), thenvisual_tokensat 4:3, 4:1 and 1:1, the axis the 16:9 ladder cannot move. Eachaspect_ladderline is the generator's output (aspect_measure.pyin the run directory), pasted whole (ADR 0012 rule 8).Each value is its grid plus the two marker tokens. The comments in
expectations.tomlgive the grids.Verified
A preflight with the new entries ran on the same image and environment, with
--quality: VERDICT PASS, PASS=27 SKIP=5, against 24 and 8 before.runs/preflight-rocm7-0344-aspect-gb43ee8e.json. The README's matrix columns do not change. Its source comment now names this run as gfx1151's newest, and the regenerated table equals the committed one byte for byte.Checks
test_verdicts.py: OK.check_source_paths.py --changed-since origin/mainis clean.amd-server/rocm-gfx1151🤖 Generated with Claude Code