Skip to content

fix(replays): always auto-load the session list - #1372

Open
JeremyFunk wants to merge 2 commits into
mainfrom
fix/replays-list-always-auto-load
Open

fix(replays): always auto-load the session list#1372
JeremyFunk wants to merge 2 commits into
mainfrom
fix/replays-list-always-auto-load

fix(replays): resume a paused session list on a key press

d269051
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 10, 2026 in 46s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge
The head change is one entry in RESUME_EVENTS, covered by a browser test that fails without it.
quality 100/100 · no findings · tests covered · risk low

The sessions list now resumes auto-loading on a key press as well as scroll, wheel and touchmove, closing the keyboard gap for a paused list. The one-line addition is safe to merge.

  • RESUME_EVENTS adds keydown, so a paused SessionsList resumes from the keyboard

Fixed since the last review

  • ✅ F1 · Paused list has no keyboard-reachable resume
What was checked
  • ResumeOnScroll binds and unbinds the same options object, so removeEventListener matches (sessions-list.tsx:109)
  • keydown on window in capture phase reaches the listener for a list too short to scroll (sessions-list.tsx:110)
  • New browser test resumes a paused list on a key press asserts a second ReachEndSentinel observer mounts

d269051 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

View more details on Maple Review Bot