wip: Don't let user provide min_balance or is_sufficient as parameters to update_asset_metadata#1062
Open
Garandor wants to merge 4 commits into
Open
wip: Don't let user provide min_balance or is_sufficient as parameters to update_asset_metadata#1062Garandor wants to merge 4 commits into
min_balance or is_sufficient as parameters to update_asset_metadata#1062Garandor wants to merge 4 commits into
Conversation
Signed-off-by: Adam Reif <Garandor@manta.network>
min_balance or is_sufficient as parameters to update_asset_metadatamin_balance or is_sufficient as parameters to update_asset_metadata
Signed-off-by: Adam Reif <Garandor@manta.network>
Garandor
commented
Apr 11, 2023
| metadata.clone().into(), | ||
| &asset_id, metadata, | ||
| )?; | ||
| AssetIdMetadata::<T>::insert(asset_id, &metadata); |
Contributor
Author
There was a problem hiding this comment.
All tests are passing but I'm 90% sure it's not safe to skip this insert. The Assets metadata got updated above and it never seems to be used from here (not sure why we store the AssetStorageMetadata anyway since we never do anything with it outside of Assets code) but frontend code might depend on asset_id_metadata returning the correct values somewhere
The interface has no mutators unfortunately, so not sure how to update the field otherwise
Signed-off-by: Adam Reif <Garandor@manta.network>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alternative 2 (see #1059) - prevent changing these
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-group to this PRA-andC-groups to this PRA-calamari,A-dolphinand/orA-mantaif your changes are meant for/impact either of these (CI depends on it)Files changedin the Github PR explorer.Situational Notes:
BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]items to check for any.