Skip to content

Fix: update_asset_metadata updates min_balance and is_sufficient#1059

Draft
Garandor wants to merge 1 commit into
mantafrom
garandor/asset_metadata
Draft

Fix: update_asset_metadata updates min_balance and is_sufficient#1059
Garandor wants to merge 1 commit into
mantafrom
garandor/asset_metadata

Conversation

@Garandor

@Garandor Garandor commented Apr 1, 2023

Copy link
Copy Markdown
Contributor

It was unintuitive that AssetManager::update_asset_metadata took min_balance and is_sufficient as parameters, but did not actually update them.

Also added a warning that this is very unsafe to do.
See also paritytech/substrate#13486

This is alternative 1

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

…ufficient`

Signed-off-by: Adam Reif <Garandor@manta.network>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P-medium Priority: Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants