Skip to content

feat: bridge Harness user questions through ACP elicitation - #21

Merged
Leeeon233 merged 1 commit into
mainfrom
feat/dsh-ask-user-bridge
Sep 20, 2026
Merged

Leeeon233 merged 1 commit into
mainfrom
feat/dsh-ask-user-bridge

Conversation

@Leeeon233

Copy link
Copy Markdown
Contributor

Problem / pressure

Harness exposes ask_user_question in its coding presets, but the ACP adapter has no user-questions/request answerer. Calls fail with NO_PROVIDER instead of prompting the user.

Summary

Register an Agent-scoped answerer and translate native questions through standard ACP form elicitation and Core 0.1.6 metadata. Preserve original ids, option labels, free text, multiple selections and custom answers. Queue per session and release pending tools on cancellation or teardown. Harness retains live/root-agent admission; plan-review displays its detail without changing Plan or permissions.

Visual explanation

Harness ask_user_question
  → userQuestions.ask (live/root validation)
  → Agent-scoped answerer / per-session queue
  → ACP elicitation/create → existing client question UI
  ← native answers ← validated ACP response

Test plan

  • Build, 34 unit tests and format check pass.
  • Native pinned Harness tool/service/Cordis/ACP smoke passes, including independent sessions, live/delegated caller rejection, signal/session cancellation, close, and existing approval behavior.
  • Actual forms round-trip through Lody's existing shared parser and response builder.
  • Four full-profile settings smoke tests pass on Node 24.15; Node 22.20 exits before initialization, an undiagnosed startup difference.

Limitations

SDK 1.3's legacy connection cannot cancel an individual outgoing form. Tool cancellation releases the local waiter and ignores late replies, but the sent card may remain until host dismissal or turn cancellation. Clients without Core answer notes retain replacement-only Other. No live desktop/model interaction was run.

@Leeeon233
Leeeon233 merged commit a5eaa8e into main Sep 20, 2026
@Leeeon233
Leeeon233 deleted the feat/dsh-ask-user-bridge branch September 20, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant