feat: bridge Harness user questions through ACP elicitation - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / pressure
Harness exposes
ask_user_questionin its coding presets, but the ACP adapter has nouser-questions/requestanswerer. Calls fail withNO_PROVIDERinstead of prompting the user.Summary
Register an Agent-scoped answerer and translate native questions through standard ACP form elicitation and Core 0.1.6 metadata. Preserve original ids, option labels, free text, multiple selections and custom answers. Queue per session and release pending tools on cancellation or teardown. Harness retains live/root-agent admission; plan-review displays its detail without changing Plan or permissions.
Visual explanation
Test plan
Limitations
SDK 1.3's legacy connection cannot cancel an individual outgoing form. Tool cancellation releases the local waiter and ignores late replies, but the sent card may remain until host dismissal or turn cancellation. Clients without Core answer notes retain replacement-only Other. No live desktop/model interaction was run.