feat: connect DSH user questions to Lody Ask Question UI - #840
Merged
Merged
Conversation
Model: gpt-6
Model: gpt-6
Model: gpt-6
Model: gpt-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Same-repository integration; no linked issue.
Problem / pressure
DeepSeek Harness coding presets expose
ask_user_question, but the ACP adapter has no answerer. Calls fail withNO_PROVIDERand never reach Lody's existing Ask Question UI.Summary
Advance the DSH submodule to a5eaa8e, which registers an Agent-scoped answerer using standard ACP elicitation and existing Core 0.1.6 metadata. Add bilingual draft specification and implementation notes. Host/UI production code and shared contracts remain unchanged.
The provider change supports multiple questions, single/multiple selections, custom answers, plan-review detail, per-session queues and cancellation/failure handling while preserving Harness live/root-agent restrictions and existing approval behavior. Provider PR LodyAI/acp-extension-dsh#21 is merged. The submodule pins its merged commit; its tree matches the previously tested implementation.
Visual explanation
Before / after
Test plan
pnpm checkandpnpm formatwere attempted but blocked by missing checkout dependencies (esbuild/oxfmt). No live desktop/model interaction was run.Limits
SDK 1.3 cannot cancel one already-sent form: an independently aborted tool stops waiting and ignores late replies, but its card can remain until host dismissal or turn cancellation. Clients without Core answer notes retain replacement-only Other. Node 22.20 full-profile startup exits before ACP initialization; this difference remains undiagnosed.