Skip to content

feat: connect DSH user questions to Lody Ask Question UI - #840

Merged
lodystage[bot] merged 4 commits into
mainfrom
feat/dsh-ask-user-bridge
Sep 20, 2026
Merged

lodystage[bot] merged 4 commits into
mainfrom
feat/dsh-ask-user-bridge

Conversation

@lodystage

@lodystage lodystage Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Related issue

Same-repository integration; no linked issue.

Problem / pressure

DeepSeek Harness coding presets expose ask_user_question, but the ACP adapter has no answerer. Calls fail with NO_PROVIDER and never reach Lody's existing Ask Question UI.

Summary

Advance the DSH submodule to a5eaa8e, which registers an Agent-scoped answerer using standard ACP elicitation and existing Core 0.1.6 metadata. Add bilingual draft specification and implementation notes. Host/UI production code and shared contracts remain unchanged.

The provider change supports multiple questions, single/multiple selections, custom answers, plan-review detail, per-session queues and cancellation/failure handling while preserving Harness live/root-agent restrictions and existing approval behavior. Provider PR LodyAI/acp-extension-dsh#21 is merged. The submodule pins its merged commit; its tree matches the previously tested implementation.

Visual explanation

DSH tool → Harness live/root validation → Agent-scoped answerer
         → per-session queue → ACP form → existing Lody Ask Question UI
         ← original question ids / answers ← validated ACP response

Before / after

Before After
DSH questions fail with NO_PROVIDER. Questions use the existing form interaction and answers return to the tool.
No ACP user-question cancellation or queue handling. Session-local queues release waiting tools on abort, cancel, close or disconnect.

Test plan

  • DSH build, 34 unit tests, native Harness/Cordis/ACP smoke and format check pass.
  • Actual DSH forms round-trip through Lody's existing shared parser, permission outcome and ACP response builders.
  • Four full-profile settings smoke tests pass on Node 24.15.
  • Root docs check and public-boundary check pass.
  • Root pnpm check and pnpm format were attempted but blocked by missing checkout dependencies (esbuild / oxfmt). No live desktop/model interaction was run.

Limits

SDK 1.3 cannot cancel one already-sent form: an independently aborted tool stops waiting and ignores late replies, but its card can remain until host dismissal or turn cancellation. Clients without Core answer notes retain replacement-only Other. Node 22.20 full-profile startup exits before ACP initialization; this difference remains undiagnosed.

@lodystage
lodystage Bot merged commit a89cab2 into main Sep 20, 2026
7 checks passed
@lodystage
lodystage Bot deleted the feat/dsh-ask-user-bridge branch September 20, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant