Skip to content

fix: integrate Kimi plan submission cards - #870

Merged
lodystage[bot] merged 2 commits into
mainfrom
fix/kimi-plan-card-integration
Sep 21, 2026
Merged

lodystage[bot] merged 2 commits into
mainfrom
fix/kimi-plan-card-integration

Conversation

@Leeeon233

Copy link
Copy Markdown
Contributor

Related issue

Maintainer-requested follow-up to #846. Adapter implementation: LodyAI/acp-extension-kimi#14 (merge first).

Problem / pressure

Enabling Kimi Plan mode did not connect submitted Markdown to Lody's dedicated plan surface. Kimi emitted generic tool content and used the other tool kind, bypassing the plan decision card.

Summary

  • Pin the Kimi adapter's plan-card fix, based on its latest main branch.
  • Verify standard Markdown plan events persist beside a completed mode-switch card, with repeated updates replacing the same document.
  • Record capability negotiation, unchanged approval behavior, historical replay limits and runtime delivery requirements in bilingual notes.

Visual explanation

Kimi ExitPlanMode resolved review
  ├─ ACP plan_update (client plan capability) → proposed_plan → shared plan panel
  └─ switch_mode tool + request_permission → existing decision controls

Before / after

Before After
Plan text inside a generic tool card Submitted Markdown reaches the shared plan panel
Exiting Plan classified as other Exiting Plan uses dedicated decision controls
No document capability negotiation Experimental plan events sent only to clients advertising support

Test plan

  • Kimi ACP suite, typecheck, and CLI runtime build passed before final rebase; suite/typecheck rerun on the rebased head.
  • Lody ACP history suite: 46 passed; plan display/virtual-row suites: 17 passed.
  • pnpm format and pnpm run docs check passed.
  • pnpm check attempted: blocked by missing dependencies/types in other packages in this nested checkout.
  • Read-only adapter diff audit completed. No production UI screenshot or published-runtime verification claimed.

Delivery limits

Merge Kimi #14 before this gitlink update. These source changes do not update an installed runtime: a separately built, published checksummed artifact and managed-runtime manifest update are still required. Native context-only ACP replay does not reconstruct past review documents; Lody retains cards it received in its own history.

@lodystage
lodystage Bot marked this pull request as ready for review September 21, 2026 05:38
@lodystage
lodystage Bot merged commit 9be3bf7 into main Sep 21, 2026
7 checks passed
@lodystage
lodystage Bot deleted the fix/kimi-plan-card-integration branch September 21, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant