Repository navigation
fix: preserve ACP missing-file errors for Kimi Plan - #846
Merged
Merged
Conversation
Model: gpt-6-astra
Model: gpt-6-astra
5 tasks done
Model: gpt-6-astra
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Model: gpt-6-astra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Companion Kimi ACP fix: LodyAI/acp-extension-kimi#12.
Problem / pressure
Enabling Kimi Plan can activate planning and then fail while reading the not-yet-created plan file. Lody currently sends that missing-file failure as an ACP internal error, so the adapter cannot distinguish it from other I/O failures and even disabling Plan can fail.
Summary
Map native
ENOENTto ACP resource-not-found in the client file-read handler. Preserve session validation, line slicing, and all other I/O failures. Advance the Kimi source submodule to the companion fix, add regression coverage, document the filesystem boundary, and record the paired diagnosis in a bilingual note.Visual explanation
Before / after
Test plan
pnpm format, changed-file lint, docs check, and public-boundary check passed. Lint has existing warnings.pnpm checkstopped on missing dependencies/type declarations in other workspace packages. Targeted CLI tests reused an existing dependency installation; this is not a clean full-workspace validation.Delivery
This client fix and the Kimi adapter fix are both required. The checksummed managed runtime must be published and its manifest advanced before shipping the complete fix. This PR does not publish a production artifact or change the installed runtime.