Skip to content

fix(ci): validate PR title only in conventional-commits check #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JerrettDavis merged 1 commit into from
Sep 23, 2026
Merged

fix(ci): validate PR title only in conventional-commits check #535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions .github/workflows/conventional-commits.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,9 @@ jobs:
failures.push(`PR title: ${title}`);
}

const commits = await github.paginate(github.rest.pulls.listCommits, {
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.payload.pull_request.number,
per_page: 100,
});

for (const commit of commits) {
const subject = commit.commit.message.split('\n')[0];
if (!allowed.test(subject) && !allowedSpecial.test(subject)) {
failures.push(`${commit.sha.substring(0, 7)}: ${subject}`);
}
}
// Only the PR title is validated. Linting every intermediate commit too broke
// automated PRs whose fixup commits (e.g. from Copilot's CI-failure auto-fix)
// aren't conventional themselves, even though the PR title is compliant.
Comment on lines +31 to +33

if (failures.length > 0) {
core.setFailed([
Expand Down
Loading