Skip to content

fix(ci): validate PR title only in conventional-commits check - #535

Merged
JerrettDavis merged 1 commit into
mainfrom
fix/conventional-commits-title-only
Sep 23, 2026
Merged

JerrettDavis merged 1 commit into
mainfrom
fix/conventional-commits-title-only

Conversation

@JerrettDavis

Copy link
Copy Markdown
Owner

PR #534's title is fully conventional, but the check also lints every individual commit, and Copilot's CI-failure auto-fix commits on that PR aren't conventional themselves — so the required check fails even though nothing wrong actually landed in the diff. Narrows validation to the PR title, which is the part that's actually enforced/visible. Not self-merging — please review.

Copilot AI lite review requested due to automatic review settings September 23, 2026 05:34
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No blocking issues remain; the only finding is a minor naming nit.

Review effort: Lite
Findings: 1 Low severity

Open (1)
What changed in this PR

This PR updates the Conventional Commits workflow to validate only pull request titles.

Changes:

  • Removes individual commit validation.
  • Retains PR title validation and failure reporting.
  • Documents the title-only behavior.
File Summary
.github/​workflows/​conventional-commits.yml Limits CI validation to PR titles.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +31 to +33
// Only the PR title is validated. Linting every intermediate commit too broke
// automated PRs whose fixup commits (e.g. from Copilot's CI-failure auto-fix)
// aren't conventional themselves, even though the PR title is compliant.
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

    12 files      12 suites   9m 33s ⏱️
 4 197 tests  4 197 ✅ 0 💤 0 ❌
13 043 runs  13 043 ✅ 0 💤 0 ❌

Results for commit f4cd1da.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 PR Validation Results

Version: ``

✅ Validation Steps

  • Build solution
  • Run tests
  • Build documentation
  • Dry-run NuGet packaging

📊 Artifacts

Dry-run artifacts have been uploaded and will be available for 7 days.


This comment was automatically generated by the PR validation workflow.

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Summary
  Generated on: 09/23/2026 - 05:42:24
  Coverage date: 09/23/2026 - 05:40:27 - 09/23/2026 - 05:42:12
  Parser: MultiReport (8x Cobertura)
  Assemblies: 5
  Classes: 1817
  Files: 611
  Line coverage: 97.4%
  Covered lines: 48650
  Uncovered lines: 1276
  Coverable lines: 49926
  Total lines: 105800
  Branch coverage: 84.4% (15618 of 18483)
  Covered branches: 15618
  Total branches: 18483
  Method coverage: 97.3% (9510 of 9772)
  Full method coverage: 91.7% (8962 of 9772)
  Covered methods: 9510
  Fully covered methods: 8962
  Total methods: 9772

PatternKit.Core                                                                                                     96.2%
  PatternKit.Application.ActivityTracking.ActivityGateState                                                          100%
  PatternKit.Application.ActivityTracking.ActivityLease                                                              100%
  PatternKit.Application.ActivityTracking.ActivityRecord                                                             100%
  PatternKit.Application.ActivityTracking.ActivityTracker                                                            100%
  PatternKit.Application.Aggregates.AggregateCommandHandler<T1, T2, T3>                                              100%
  PatternKit.Application.Aggregates.AggregateCommandResult<T>                                                        100%
  PatternKit.Application.Aggregates.AggregateRoot<T1, T2>                                                            100%
  PatternKit.Application.AntiCorruption.AntiCorruptionLayer<T1, T2>                                                 90.4%
  PatternKit.Application.AntiCorruption.AntiCorruptionResult<T>                                                      100%
  PatternKit.Application.AuditLog.AuditLogAppendResult<T>                                                           85.7%
  PatternKit.Application.AuditLog.InMemoryAuditLog<T1, T2>                                                          95.4%
  PatternKit.Application.BoundedContexts.BoundedContextAdapter                                                       100%
  PatternKit.Application.BoundedContexts.BoundedContextCapability                                                   83.3%
  PatternKit.Application.BoundedContexts.BoundedContextDescriptor                                                   95.4%
  PatternKit.Application.CompensatingTransactions.CompensatingTransaction<T>                                        96.9%
  PatternKit.Application.CompensatingTransactions.CompensatingTransactionExecution<T>                                100%
  PatternKit.Application.CompensatingTransactions.CompensatingTransactionRecord                                      100%
  PatternKit.Application.CompensatingTransactions.CompensatingTransactionStep<T>                                     100%
  PatternKit.Application.CompensatingTransactions.CompensatingTransactionStepBuilder<T>                              100%
  PatternKit.Application.ContextMaps.ContextMapDescriptor                                                           96.8%
  PatternKit.Application.ContextMaps.ContextMapRelationship                                                          100%
  PatternKit.Application.DataMapping.DataMapper<T1, T2>                                                             94.6%
  PatternKit.Application.DataMapping.DataMapperError                                                                  90%
  PatternKit.Application.DataMapping.DataMapperResult<T>                                                            84.6%
  PatternKit.Application.DomainEvents.DomainEventDispatcher<T>                                                      95.4%
  PatternKit.Application.DomainEvents.DomainEventDispatchResult                                                      100%
  PatternKit.Application.DomainServices.DomainServiceOperation<T1, T2>                                               100%
  PatternKit.Application.DomainServices.DomainServiceRegistry<T1, T2>                                                100%
  PatternKit.Application.EventSourcing.EventStoreAppendResult                                                        100%
  PatternKit.Application.EventSourcing.InMemoryEventStore<T1, T2>                                                   97.9%
  PatternKit.Application.EventSourcing.StoredEvent<T1, T2>                                                            80%
  PatternKit.Application.EventualConsistency.EventualConsistencyEvaluation<T>                                       92.3%
  PatternKit.Application.EventualConsistency.EventualConsistencyMonitor<T>                                          97.2%
  PatternKit.Application.EventualConsistency.EventualConsistencyMonitorState<T>                                      100%
  PatternKit.Application.EventualConsistency.EventualConsistencyWatermarks<T>                                       96.7%
  PatternKit.Application.FeatureToggles.FeatureToggleDecision                                                       87.5%
  PatternKit.Application.FeatureToggles.FeatureToggleRule<T>                                                         100%
  PatternKit.Application.FeatureToggles.FeatureToggleSet<T>                                                         96.9%

@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.44%. Comparing base (02c1eef) to head (f4cd1da).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main     #535     +/-   ##
=========================================
  Coverage   97.44%   97.44%             
=========================================
  Files         611      611             
  Lines       49926    49926             
  Branches     3230       34   -3196     
=========================================
+ Hits        48650    48652      +2     
+ Misses       1276     1274      -2     
Flag Coverage Δ
unittests 97.44% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants