Skip to content

Remove OTEL Activity from circuit breaker to fix trace ID leak #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 1 commit into from
Apr 10, 2026
Merged

Remove OTEL Activity from circuit breaker to fix trace ID leak #2495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Wolverine/ErrorHandling/CircuitBreaker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,6 @@ public async ValueTask UpdateTotalsAsync(DateTimeOffset time, int failures, int

if (failures > 0 && ShouldStopProcessing())
{
using var activity = WolverineTracing.ActivitySource.StartActivity(WolverineTracing.CircuitBreakerTripped);
activity?.SetTag(WolverineTracing.EndpointAddress, _circuit.Endpoint.Uri);
await _circuit.PauseAsync(Options.PauseTime);

if (_observer != null)
Expand Down
2 changes: 0 additions & 2 deletions src/Wolverine/Transports/ListeningAgent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,6 @@ public async ValueTask PauseAsync(TimeSpan pauseTime)
{
try
{
using var activity = WolverineTracing.ActivitySource.StartActivity(WolverineTracing.PausingListener);
activity?.SetTag(WolverineTracing.EndpointAddress, Uri);
// Do NOT pre-latch the receiver here. PauseAsync may be called from within the
// handler pipeline (e.g. via RateLimitContinuation → PauseListenerContinuation).
// Pre-latching causes DrainAsync to wait for the ActionBlock to drain, which
Expand Down
Loading