Remove OTEL Activity from circuit breaker to fix trace ID leak#2495
Merged
Conversation
…leak (#2494) After a circuit breaker trip/resume cycle, the Activity started on the background batching thread leaked its trace context via AsyncLocal into subsequent message processing, causing all new messages to inherit the stale trace ID. Remove the Activity creation from both the circuit breaker trip handler and the listener PauseAsync method to prevent this contamination. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 11, 2026
This was referenced Apr 18, 2026
This was referenced Apr 25, 2026
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Activitycreation from the circuit breaker trip handler (CircuitBreaker.UpdateTotalsAsync) and the listenerPauseAsyncmethodActivity.Current(stored inAsyncLocal) leaking from the background batching thread into message processing threads after the listener restartedTest plan
🤖 Generated with Claude Code