feat(review): wire remaining configured gate blockers into signal tracking (#8104)

[andriypolanski]

Summary

• Closes calibration: wire recordRuleFired/recordHumanOverride for the remaining isConfiguredGateBlocker codes (excludes linked_issue_scope_mismatch, covered by #8101) #8104
• Adds recordConfiguredGateBlockerSignals in src/rules/advisory.ts: after evaluateGateCheck, records a RuleFiredEvent for every finding isConfiguredGateBlocker would block, except linked_issue_scope_mismatch (owned by calibration: wire linked_issue_scope_mismatch into the shared signal-tracking module (fired + reversal) #8101 / open PR feat(review): wire linked_issue_scope_mismatch into the shared signal-tracking module #8109). Wired from the main review gate path in src/queue/processors.ts. evaluateGateCheck stays sync/pure for engine parity.
• Generalizes reversal overrides in recordReversalSignals (src/review/outcomes-wire.ts): on contributor reopen and owner reopen-then-merge, a fixed 30-day lookback over CONFIGURED_GATE_BLOCKER_SIGNAL_CODES records "reversed" HumanOverrideEvents for codes with a prior fire on that target. Same fail-open discipline as Extract a shared, deployment-agnostic calibration/signal-tracking module for ORB + AMS #7982 / calibration: wire linked_issue_scope_mismatch into the shared signal-tracking module (fired + reversal) #8101.
• No "confirmed" path (Design a positive-confirmation ('this automated decision was correct') signal #8106).

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npx vitest run test/unit/configured-gate-blocker-signals.test.ts test/unit/outcomes-wire.test.ts — 76 passed
• npm run test:coverage
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

• Ran the exact suites for both new call sites: fired-signal helper + reversal overrides. Covered ai_consensus_defect, ai_review_split, secret_leak / missing_linked_issue; explicit no-fire for linked_issue_scope_mismatch; no-fire when isConfiguredGateBlocker is false; multi-code reversal on reopen and owner reopen-then-merge; no reversal without a prior fire; SignalStore reject fail-open on both paths; severity ?? "blocker" and confidence present/absent branches. Processors wiring is exercised by existing queue gate-publish tests. Untouched surfaces (actionlint/workers/mcp/ui) left to CI.

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

Not applicable — backend-only calibration wiring (no UI, docs, or extension surface touched; no visible behavior change — blocking behavior is untouched).

Notes

• Complements calibration: wire linked_issue_scope_mismatch into the shared signal-tracking module (fired + reversal) #8101 (open PR feat(review): wire linked_issue_scope_mismatch into the shared signal-tracking module #8109). When that lands, prefer folding its single-code override into this generalized loop rather than two redundant lookups — this PR excludes linked_issue_scope_mismatch so there is no double-count today.
• Fail-open tests use a rejecting SignalStore double via vi.spyOn(signalTrackingWire, "createSignalStore").

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.62%. Comparing base (e2d8ef8) to head (82137c1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8119      +/-   ##
==========================================
+ Coverage   89.52%   89.62%   +0.10%     
==========================================
  Files          97       86      -11     
  Lines       22573    24291    +1718     
  Branches     3861     4939    +1078     
==========================================
+ Hits        20208    21771    +1563     
- Misses       2187     2242      +55     
- Partials      178      278     +100     

Flag	Coverage Δ
control-plane	?
shard-1	76.61% <54.16%> (?)
shard-2	37.91% <79.16%> (?)
shard-3	39.78% <62.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/queue/processors.ts	95.76% <100.00%> (ø)
src/review/outcomes-wire.ts	90.54% <100.00%> (ø)
src/rules/advisory.ts	97.88% <100.00%> (ø)

... and 14 files with indirect coverage changes

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-22 23:33:33 UTC}

5 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This PR wires recordConfiguredGateBlockerSignals (RuleFiredEvent) and a generalized recordConfiguredGateBlockerOverrides (reversal HumanOverrideEvent) for every isConfiguredGateBlocker code except linked_issue_scope_mismatch, which #8101 already owns. The recording call in processors.ts is placed right after evaluateGateCheck with the exact same advisory+policy inputs, and evaluateGateCheckCore's pure filter (isConfiguredGateBlocker) is mirrored exactly in recordConfiguredGateBlockerSignals, so the two stay in lock-step by construction. All writes are fail-open (.catch swallow at each call site, plus an inner try/catch per-code in the reversal loop), matching the established #7982/#8101 discipline, and the new CONFIGURED_GATE_BLOCKER_SIGNAL_CODES list is unit-tested against the actual isConfiguredGateBlocker branches (ai_consensus_defect, ai_review_split, secret_leak, missing_linked_issue, and the linked_issue_scope_mismatch exclusion).

Nits — 5 non-blocking

• src/queue/processors.ts:10302-10303 calls recordConfiguredGateBlockerSignals only `if (evaluation)`, i.e. only when shouldEvaluateGate was true — worth a one-line comment confirming that's intentional (skip-gate paths shouldn't record blocker signals) rather than an oversight, since it's easy to misread as accidentally gated on the wrong condition.
• The external brief's 'magic numbers 8104' flags are just issue-number references in comments, not real magic numbers — no action needed.
• src/rules/advisory.ts's CONFIGURED_GATE_BLOCKER_SIGNAL_CODES doc comment already documents the intentional exclusion and the sync requirement, but consider adding a compile-time or test-time assertion that the list stays in sync with isConfiguredGateBlocker's body (today it relies purely on a code comment and manual test coverage).
• recordConfiguredGateBlockerOverrides in outcomes-wire.ts duplicates the try/catch-per-code shape already used by the (now-superseded in spirit) recordLinkedIssueScopeMismatchOverride — consider whether the older function could now be expressed as a one-code call into the generalized helper to reduce duplication, though the PR description explains why calibration: wire linked_issue_scope_mismatch into the shared signal-tracking module (fired + reversal) #8101 stays separately owned.
• Consider a small dev-time test (e.g. iterating over a fixed set of AdvisoryFinding codes through isConfiguredGateBlocker under permissive policies) that asserts every blocking code the real function can return is present in CONFIGURED_GATE_BLOCKER_SIGNAL_CODES, so the list can't silently drift the next time isConfiguredGateBlocker gains a new code.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8104
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 211 registered-repo PR(s), 135 merged, 22 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	andriypolanski; Gittensor profile; 211 PR(s), 22 issue(s).
Improvement	✅ Minor	risk: clean · value: minor

Linked issue satisfaction

Addressed
The diff adds recordConfiguredGateBlockerSignals in advisory.ts wired from processors.ts to record recordRuleFired for every configuredBlockers finding except linked_issue_scope_mismatch, and generalizes recordReversalSignals in outcomes-wire.ts to check CONFIGURED_GATE_BLOCKER_SIGNAL_CODES (excluding that code) for prior fires and record reversed HumanOverrideEvents, matching the issue's two requ

Review context

• Author: andriypolanski
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, TypeScript, JavaScript, Rust, Cuda, Kotlin, MDX, Scala
• Official Gittensor activity: 211 PR(s), 22 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.