feat(review): wire linked_issue_scope_mismatch into the shared signal-tracking module

[RealDiligent]

Summary

• Closes calibration: wire linked_issue_scope_mismatch into the shared signal-tracking module (fired + reversal) #8101
• The AI-confidence-driven linked_issue_scope_mismatch finding carries real gate authority (block mode + unaddressed hard-blocks a PR) yet was invisible to the shared calibration module (Extract a shared, deployment-agnostic calibration/signal-tracking module for ORB + AMS #7982): createSignalStore's ORB adapter existed with zero live callers, so neither the self-correction pipeline (Same-rule repeat alarm: fast-path detection when one deterministic rule rejects N distinct targets in a short window #7983/Per-rule (not just per-project) precision tracking in the gate-eval pipeline #7984) nor this epic's backtest primitives (calibration: pure BacktestCase corpus builder from RuleFiredEvent/HumanOverrideEvent pairs #8083–calibration: Pareto-floor comparator between two BacktestScoreReports #8086) could see this judgment's history. This wires exactly one finding code and one override direction (reversal), per the issue's scope.
• Fired: inside the existing block-mode + unaddressed finding-push block in src/queue/processors.ts — and ONLY there (advisory mode never pushes the finding, so it never records either) — createSignalStore(env).recordRuleFired(...) records {ruleId, targetKey: repo#pr, outcome, occurredAt: nowIso(), metadata: {confidence}}, best-effort with .catch(() => undefined), matching the adjacent cache-write discipline and SignalStore's own never-fail-the-review contract.
• Reversed: when recordReversalSignals (src/review/outcomes-wire.ts) records a reversal — both the contributor-reopen path and Count an owner reopen-then-merge as a real reversal signal, not administrative noise #7985's owner reopen-then-merge path — a fixed 30-day queryRuleHistory lookback checks for a linked_issue_scope_mismatch firing against the same target and, if present, records a "reversed" HumanOverrideEvent: the human undoing of the bot action IS the human judgment on that finding. Same .catch(() => undefined) discipline — a SignalStore failure (including the deliberately-propagating queryRuleHistory read error) never affects whether the underlying reversal itself records.
• No "confirmed" path, per the issue's Boundaries (no positive-confirmation signal exists anywhere in the codebase to mirror), and no change to linkedIssueSatisfactionGateMode's blocking behavior — this only records data about decisions already being made.

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

• Ran the exact suites for both touched functions: vitest run test/unit/outcomes-wire.test.ts test/unit/linked-issue-satisfaction-run.test.ts — 123 tests green, including the new cases — plus the full root npm run typecheck. Verified per-diff-line coverage via lcov intersection: every changed line and branch in both processors.ts and outcomes-wire.ts is covered (fired at block+unaddressed with confidence metadata; NO fired for advisory mode or addressed/partial; "reversed" on both reversal paths gated on a prior firing; no override without one; and both fail-open .catch paths exercised explicitly via a rejecting SignalStore double — normal return values and the underlying reversal unaffected). Also simulated the scoped-CI shard condition with the exact CI invocation (--changed=origin/main --coverage.all=false): the lcov is non-empty and contains both changed instrumented files. actionlint/workers/mcp/ui checks are untouched surfaces; CI runs them all.

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
• API/OpenAPI/MCP behavior is updated and tested where needed.
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

Not applicable — backend-only wiring (no UI, docs, or extension surface touched; no visible behavior change — the finding's blocking behavior is untouched).

Notes

• The fail-open tests use a rejecting SignalStore double via vi.spyOn(signalTrackingWire, "createSignalStore") — the issue's explicit requirement that a test exercising the failure path is mandatory, not optional. The write path in processors.ts keeps its own .catch(() => undefined) even though the live adapter's writes are internally best-effort, so the review pass stays safe under any future SignalStore implementation.
• The 30-day lookback is a fixed constant (LINKED_ISSUE_SCOPE_MISMATCH_LOOKBACK_MS), not configurable, per the issue's requirement.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (d07b057) to head (3fc2bed).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8109      +/-   ##
==========================================
- Coverage   92.01%   90.28%   -1.74%     
==========================================
  Files         757       99     -658     
  Lines       77228    25905   -51323     
  Branches    23346     5027   -18319     
==========================================
- Hits        71061    23388   -47673     
+ Misses       5061     2245    -2816     
+ Partials     1106      272     -834     

Flag	Coverage Δ
shard-1	77.34% <40.00%> (+22.25%)	⬆️
shard-2	33.67% <80.00%> (-17.49%)	⬇️
shard-3	38.56% <20.00%> (-17.62%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/queue/processors.ts	95.76% <100.00%> (+<0.01%)	⬆️
src/review/outcomes-wire.ts	90.10% <100.00%> (+0.43%)	⬆️

... and 658 files with indirect coverage changes

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-22 22:57:16 UTC}

4 files · 1 AI reviewer · no blockers · readiness 98/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This PR wires the linked_issue_scope_mismatch AI finding into the shared signal-tracking module: recordRuleFired is called only in the block-mode + unaddressed finding-push branch of runLinkedIssueSatisfactionForAdvisory (processors.ts), and a 30-day queryRuleHistory lookback in recordReversalSignals (outcomes-wire.ts) records a 'reversed' HumanOverrideEvent when a matching target is later reversed via contributor-reopen or the owner reopen-then-merge path. Both writes use .catch(() => undefined) matching the file's existing best-effort discipline, and the tests directly verify the fired/no-fired/override/no-override/failure-degrades-silently matrix end-to-end. The change is narrowly scoped to exactly one rule and one override direction as described, with no change to gate-blocking behavior itself.

Nits — 3 non-blocking

• src/review/outcomes-wire.ts: recordLinkedIssueScopeMismatchOverride's own internal store.recordHumanOverride call is not wrapped in try/catch — it only becomes safe because every call site externally chains .catch(() => undefined); worth a comment noting this function is not itself safe to call unguarded.
• The 30-day fixed lookback in queryRuleHistory (LINKED_ISSUE_SCOPE_MISMATCH_LOOKBACK_MS) is a magic window with no config knob — fine per the issue's stated boundaries, but worth confirming that's intentional versus reusing OWNER_REOPEN_MERGE_WINDOW_MS-style named constants elsewhere in the file for consistency.
• Consider extracting a short doc-comment on recordLinkedIssueScopeMismatchOverride noting its caller-must-catch contract, since a future caller might reasonably assume it's self-contained given how consistently other helpers in this file use internal try/catch.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8101
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 361 registered-repo PR(s), 144 merged, 38 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	RealDiligent; Gittensor profile; 361 PR(s), 38 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The diff wires recordRuleFired at the exact block-mode+unaddressed finding-push site in processors.ts and wires a 'reversed' recordHumanOverride into both reversal paths of recordReversalSignals gated on a prior fired event via queryRuleHistory, matching the issue's scope and fail-open .catch discipline exactly as specified, with tests covering fired/no-fired cases, both reversal paths, no-prior-f

Review context

• Author: RealDiligent
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, Ruby, JavaScript, Svelte, TypeScript, Markdown, MDX, Rust
• Official Gittensor activity: 361 PR(s), 38 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.